docs: verify a dropped merge-queue entry via the issue timeline before re-arming#99
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the git workflow to include instructions on verifying 'dropped' merge queue entries using the GitHub API issue timeline. The reviewer provided a suggestion to improve the efficiency and safety of the jq command used in the documentation by using optional chaining and the IN function.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…rming gh pr view state and the queue listing lag for minutes after a queue merge — the stale read looks identical to a silent drop. The issue timeline (removed_from_merge_queue followed by merged) is authoritative. Also notes that queue membership is GraphQL-only, not a gh pr view --json field. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
dfa9030 to
047ffd2
Compare
Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
What
Adds a paragraph + recipe to the Recovery when armed too early section of
references/pull-request-workflow.md: right after a queue merge,gh pr view --json statecan reportOPENand the queue listing can show the entry gone for several minutes — indistinguishable from the documented silent-drop failure mode, except the PR already merged. The issue timeline (removed_from_merge_queuefollowed bymerged) is the authoritative discriminator. Also notesisInMergeQueue/mergeQueueEntryare GraphQL-only, notgh pr view --jsonfields.Why
Live case (netresearch/t3x-nr-llm PR #403, 2026-07-16): the stale read showed OPEN + empty queue while the timeline showed the merge had completed a minute earlier — the current guidance would have re-armed an already-merged PR.