feat: add .pre-commit-config.yaml mirroring CI checks#78
Merged
Conversation
Wires netresearch/skill-repo-skill@v1.22.0 as a pre-commit hook provider so validate-skill, check-version-parity, and the standard linter set (markdownlint-cli2, yamllint, actionlint, ruff, shellcheck) run locally before commit instead of only in CI. - package.json scripts.prepare: invokes pre-commit install --install-hooks if pre-commit is on PATH; silent no-op otherwise. Auto-activates hooks on `npm install`. Part of the fleet rollout following netresearch/agent-harness-skill#27 (CI/Hook Parity Principle) and skill-repo-skill v1.22.0 (hook exposure). Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
Adds local pre-commit tooling to mirror CI validation for this skill repository and auto-installs hooks when possible during npm setup.
Changes:
- Adds
.pre-commit-config.yamlwith validation, linting, formatting, and shell checks pinned to specific hook versions. - Adds an npm
preparescript intended to install pre-commit hooks automatically whenpre-commitis available.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Defines the local pre-commit hook set matching CI validation/lint checks. |
package.json |
Adds a lifecycle script to install pre-commit hooks during npm setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a .pre-commit-config.yaml file and a prepare script in package.json to automate hook installation. Feedback highlights that several specified hook versions are non-existent and will cause failures. Additionally, the yamllint hook references a missing configuration file, and it is suggested to remove the --install-hooks flag from the package.json script to improve developer experience by avoiding slow installation times.
Merged
CybotTM
added a commit
that referenced
this pull request
May 28, 2026
Release **v2.15.0** (minor bump, conventional commits since v2.14.0). Bumps `.claude-plugin/plugin.json` + `SKILL.md` version to 2.15.0. Changes since v2.14.0: - feat: add .pre-commit-config.yaml mirroring CI checks - - Wires netresearch/skill-repo-skill@v1.22.0 as a pre-commit hook - provider so validate-skill, check-version-parity, and the standard - linter set (markdownlint-cli2, yamllint, actionlint, ruff, shellcheck) - run locally before commit instead of only in CI. - - package.json scripts.prepare: invokes pre-commit install --install-hooks - if pre-commit is on PATH; silent no-op otherwise. Auto-activates hooks - on `npm install`. - - Part of the fleet rollout following netresearch/agent-harness-skill#27 - (CI/Hook Parity Principle) and skill-repo-skill v1.22.0 (hook exposure). - - Signed-off-by: Sebastian Mendel <info@sebastianmendel.de> - feat: add .pre-commit-config.yaml mirroring CI checks (#78) - - ## Summary - - Wires - [`netresearch/skill-repo-skill@v1.22.0`](https://github.com/netresearch/skill-repo-skill/releases/tag/v1.22.0) After merge: a signed tag `v2.15.0` on `main` triggers the release workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires
netresearch/skill-repo-skill@v1.22.0as a pre-commit hook provider sovalidate-skill,check-version-parity, plus markdownlint-cli2 / yamllint / actionlint / ruff / shellcheck run locally before commit.Part of the fleet rollout following the CI/Hook Parity Principle in netresearch/agent-harness-skill#27. Pilot phase (skill-repo-skill#109, go-development-skill#34, security-audit-skill#71, php-modernization-skill#57) validated the template across with/without yamllint and with/without package.json configurations.
Files
.pre-commit-config.yaml— standard NR skill-repo hook set (pre-commit-hooks meta, validate-skill, check-version-parity, markdownlint-cli2, yamllint, actionlint, ruff, shellcheck)