fix: resolve ruff lint errors in Python scripts#20
Merged
Conversation
Remove unused pathlib.Path import from matrix-doctor.py and add ruff.toml to suppress E402 for e2ee scripts where nio imports must follow the check_e2ee_dependencies() guard.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a Ruff configuration to ignore E402 linting errors for specific Matrix E2EE scripts and removes an unused import in matrix-doctor.py. Feedback was provided to refine the glob pattern in ruff.toml for better precision and to avoid matching unintended files.
| @@ -0,0 +1,3 @@ | |||
| [lint.per-file-ignores] | |||
| # E402: nio imports must come after check_e2ee_dependencies() call | |||
| "skills/matrix-communication/scripts/matrix-*e2ee*.py" = ["E402"] | |||
There was a problem hiding this comment.
The glob pattern matrix-*e2ee*.py is a bit broad and could match unintended files in the future (e.g., a new file named matrix-e2ee.py). For better precision and maintainability, consider using two more specific globs to cover the existing file patterns.
Suggested change
| "skills/matrix-communication/scripts/matrix-*e2ee*.py" = ["E402"] | |
| "skills/matrix-communication/scripts/matrix-e2ee-*.py" = ["E402"] | |
| "skills/matrix-communication/scripts/matrix-*-e2ee.py" = ["E402"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pathlib.Pathimport frommatrix-doctor.py(F401)ruff.tomlto suppress E402 for e2ee scripts wherefrom nio importmust follow thecheck_e2ee_dependencies()guard callTest plan