Skip to content

Add waiting screen to validate and centralise CentralWaitingScreen#693

Open
AdityaGupta716 wants to merge 4 commits intoneuroinformatics-unit:mainfrom
AdityaGupta716:feature-waiting-screen-validate
Open

Add waiting screen to validate and centralise CentralWaitingScreen#693
AdityaGupta716 wants to merge 4 commits intoneuroinformatics-unit:mainfrom
AdityaGupta716:feature-waiting-screen-validate

Conversation

@AdityaGupta716
Copy link
Contributor

Description

What does this PR do?

  • Adds a waiting screen when validating with include_central=True and the connection method is not local_filesystem (i.e. ssh, aws, gdrive), where the connection can be slow
  • Centralises the waiting screen logic by replacing SearchingCentralForNextSubSesPopup and ValidatingCentralPopup with a single reusable CentralWaitingScreen(message: str) class

Why is this PR needed?

Fixes #604

What is the approach?

Is this a breaking change?

No

How has this PR been tested?

All 65 TUI tests pass locally.

Checklist

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The code has been formatted with pre-commit

@JoeZiminski
Copy link
Member

Thanks @AdityaGupta716! This is a nice feature addition, I will try and take a look at this over the next few weeks. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add waiting screen to validate

2 participants