Add waiting screen to validate and centralise CentralWaitingScreen#693
Open
AdityaGupta716 wants to merge 4 commits intoneuroinformatics-unit:mainfrom
Open
Add waiting screen to validate and centralise CentralWaitingScreen#693AdityaGupta716 wants to merge 4 commits intoneuroinformatics-unit:mainfrom
AdityaGupta716 wants to merge 4 commits intoneuroinformatics-unit:mainfrom
Conversation
…e waiting screen (Fixes neuroinformatics-unit#604)
for more information, see https://pre-commit.ci
Member
|
Thanks @AdityaGupta716! This is a nice feature addition, I will try and take a look at this over the next few weeks. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
include_central=Trueand the connection method is notlocal_filesystem(i.e.ssh,aws,gdrive), where the connection can be slowSearchingCentralForNextSubSesPopupandValidatingCentralPopupwith a single reusableCentralWaitingScreen(message: str)classWhy is this PR needed?
Fixes #604
What is the approach?
CentralWaitingScreentakes amessagestring, displays aLabel+LoadingIndicator, consistent with the pattern established in Suggest next sub ses remote #484 and ADD: Workers for transferring data and Loading Animation #479@work(exclusive=True, thread=True)thread, UI updates usecall_from_thread, matching the existing sub/ses suggestion patternIs this a breaking change?
No
How has this PR been tested?
All 65 TUI tests pass locally.
Checklist