Fix: Replace bare and broad exceptions with NeuroBlueprintError#699
Open
Kayd-06 wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Open
Fix: Replace bare and broad exceptions with NeuroBlueprintError#699Kayd-06 wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Kayd-06 wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Conversation
Member
|
Thanks @Kayd-06, this looks good. but will hold off reviewing and merging until after the next big release, in case it has some unintended side-effects. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Bare
except:blocks and overly broadexcept Exception:catches can intercept critical system-level exceptions likeKeyboardInterruptandSystemExit, as well as mask unexpected application bugs (likeAttributeErrororIndexError). This makes debugging extremely difficult and hides actual bugs.What does this PR do?
except:block and anexcept Exception:block in datashuttle/utils/validation.py withexcept NeuroBlueprintError:.NeuroBlueprintErrorwhen regex parsing of a BIDS value comes up empty, instead of implicitly causing anIndexError. This allows the validation logic to safely and explicitly catch the expected error.References
N/A
How has this PR been tested?
The test suite was run locally using
pytest. The test_validation_unit.py module passed successfully, confirming the previous behavior of the validation functions remains intact while safely catching the intended exceptions.Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: