Skip to content

Implement collapsible navigation and table of contents in documentation#7

Merged
m-prosper-10 merged 4 commits into
mainfrom
integration
May 20, 2026
Merged

Implement collapsible navigation and table of contents in documentation#7
m-prosper-10 merged 4 commits into
mainfrom
integration

Conversation

@m-prosper-10

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented May 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
neurolab-docs Error Error May 20, 2026 7:45pm

@m-prosper-10 m-prosper-10 merged commit 3e590fd into main May 20, 2026
5 of 8 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cbdcc11dac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/config/docs.ts
},
{
title: 'Data Prep',
href: '/docs/architecture/data-prep',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove sidebar routes that point to non-existent docs pages

This commit adds many new href entries under docsConfig.sidebarNav that do not have corresponding route files under src/app/docs (for example /docs/architecture/data-prep), so clicking them in the desktop or mobile nav now leads users to 404 pages. Because these links are prominently exposed in navigation, this is a user-facing regression rather than a content gap hidden from users.

Useful? React with 👍 / 👎.

Comment thread src/components/toc.tsx
}, 100)

return () => clearTimeout(timer)
}, []) // eslint-disable-line react-hooks/exhaustive-deps

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Recompute ToC items when navigating between docs pages

The TOC heading scan runs only once (useEffect(..., [])), but this component is mounted from the shared /docs layout, so client-side navigation between docs pages reuses the same instance and leaves items stale from the previous page. As a result, the “On This Page” links can reference headings from a different document after route changes.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant