You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 23, 2025. It is now read-only.
A further refinement would be to allow creating these sharing links from within the voilà dashboard itself, but this may require some introspection (see if we are running from within a binderhub service, obtain the hostname etc.)
When I run it locally (with the command in the README), the QUERY_STRING env variable does not seem to be set -- so the example query is always used. Do you observe this too?
Also, should we redirect to a URL including the query when the user enters text in the box and hits the "run query" button?
Did you run voilà >= 0.2.2 (the query string feature is fairly recent) ?
It seems to run locally in my case (see screenshot)
Regarding the URL redirection, that's an excellent idea but it would cause the whole page execution to restart IIUC (including loading the model...) which would be fairly slow I guess. A possible hacky workaround might be to edit the URL in-place (that might require some JS?) but I guess a "share query" link in the UI itself would be a good first step and generally more useful, given that, for instance, when running the dashboard in a binderhub setting, copying URLs from the navbar would be ineffective (these point to a temporary single-user jupyter server that gets destroyed after a period of inactivity)
Regarding the URL redirection, that's an excellent idea but it would cause the whole page execution to restart IIUC (including loading the model...) which would be fairly slow I guess. A possible hacky workaround might be to edit the URL in-place (that might require some JS?)
that's true! let's forget about changing the URL
but I guess a "share query" link in the UI itself would be a good first step and generally more useful, given that, for instance, when running the dashboard in a binderhub setting, copying URLs from the navbar would be ineffective (these point to a temporary single-user jupyter server that gets destroyed after a period of inactivity)
that's a much better idea! I guess we could even have a "copy to clipboard"
button. I may have some time to look into it this weekend but I'm not sure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows the sharing of links pointing directly to a query, which is an important feature in the main neuroquery website.
For instance, try https://notebooks.gesis.org/binder/v2/gh/rprimet/neuroquery_apps/query_string?urlpath=%2Fvoila%2Frender%2Fminimal_dashboard.py%3Fquery%3Dadhd
A further refinement would be to allow creating these sharing links from within the voilà dashboard itself, but this may require some introspection (see if we are running from within a binderhub service, obtain the hostname etc.)