Draft
Conversation
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1670 +/- ##
==========================================
- Coverage 81.88% 81.87% -0.02%
==========================================
Files 215 215
Lines 25861 25851 -10
Branches 4108 4107 -1
==========================================
- Hits 21177 21166 -11
- Misses 3303 3305 +2
+ Partials 1381 1380 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR attempts to fix an issue where some modules are not loaded in the environment section of the UI (the modules do not get passed into the
update_loaded_modulesendpoint.)Previously the logic attempted to load as many modules as possible during a 2 second window by iterating through a plugins generator. However, it seems that some modules get missed (likely iterated but lacking the time to complete the information transfer to the endpoint).
Loading one module per harvest cycle is the attempt at fixing this. If the application completes before all the modules habe had time to load, the agent will revert to the previous connect logic of converting the remaining (unloaded) modules to a list and uploading them at once. The rationale is that the more modules an application has, the higher the likelihood that the application will be running longer as well.