Skip to content

Combine framework_graphql_py3 file with framework_graphql#1672

Open
TimPansino wants to merge 1 commit intomainfrom
fix-combine-py3-file
Open

Combine framework_graphql_py3 file with framework_graphql#1672
TimPansino wants to merge 1 commit intomainfrom
fix-combine-py3-file

Conversation

@TimPansino
Copy link
Contributor

Overview

  • Separate files for Python 3 code are unnecessary now, remove this file we missed when ripping out Python 2.

@TimPansino TimPansino requested a review from a team as a code owner February 26, 2026 22:11
@github-actions
Copy link

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.96s
✅ MARKDOWN markdownlint 7 0 0 0 1.41s
✅ PYTHON ruff 1035 0 0 0 1.02s
✅ PYTHON ruff-format 1035 0 0 0 0.41s
✅ YAML prettier 15 0 0 0 1.51s
✅ YAML v8r 15 0 0 5.1s
✅ YAML yamllint 15 0 0 0.62s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.87%. Comparing base (983474f) to head (82810dc).

Files with missing lines Patch % Lines
newrelic/hooks/framework_graphql.py 92.10% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1672      +/-   ##
==========================================
- Coverage   81.88%   81.87%   -0.01%     
==========================================
  Files         215      214       -1     
  Lines       25861    25858       -3     
  Branches     4108     4108              
==========================================
- Hits        21177    21172       -5     
- Misses       3303     3305       +2     
  Partials     1381     1381              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants