Skip to content

Add functions to get 3D krypton maps#948

Open
mcidlaso wants to merge 7 commits into
next-exp:masterfrom
mcidlaso:ICAROS_3D
Open

Add functions to get 3D krypton maps#948
mcidlaso wants to merge 7 commits into
next-exp:masterfrom
mcidlaso:ICAROS_3D

Conversation

@mcidlaso
Copy link
Copy Markdown

@mcidlaso mcidlaso commented Dec 19, 2025

These scripts contain functions to:

  • Make cuts on the outputs from sophronia to get the selected events and the efficiencies of the cuts
  • Get the lifetime and drift velocity for each run
  • Compute 3D krypton maps and apply them to correct the data
  • Some tests for these functions (still have a lot of work to do)

Copy link
Copy Markdown
Collaborator

@gonzaponte gonzaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round

Comment thread invisible_cities/icaros/correction_functions.py Outdated
Comment thread invisible_cities/icaros/correction_functions.py Outdated
Comment thread invisible_cities/icaros/correction_functions_test.py Outdated
Comment thread invisible_cities/icaros/krmap_functions.py Outdated
Comment thread invisible_cities/icaros/krmap_functions.py Outdated
Comment thread invisible_cities/icaros/selection_functions.py Outdated
Comment thread invisible_cities/icaros/selection_functions.py Outdated
Comment thread invisible_cities/icaros/selection_functions.py Outdated
Comment thread invisible_cities/icaros/selection_functions.py Outdated
Comment thread invisible_cities/icaros/selection_functions.py Outdated
Copy link
Copy Markdown
Collaborator

@gonzaponte gonzaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments. We will need to build up a bit more testing and put everything together in a city.

Comment thread invisible_cities/icaros/correction_functions.py Outdated
Comment thread invisible_cities/icaros/correction_functions.py Outdated
Comment thread invisible_cities/icaros/correction_functions.py Outdated
Comment thread invisible_cities/icaros/correction_functions_test.py Outdated
Comment thread invisible_cities/icaros/krmap_functions.py Outdated
Comment thread invisible_cities/icaros/lifetime_vdrift_functions.py Outdated
Comment thread invisible_cities/icaros/lifetime_vdrift_functions.py Outdated
Comment thread invisible_cities/icaros/krmap_functions_test.py Outdated
Comment thread invisible_cities/icaros/krmap_functions_test.py Outdated
Comment thread invisible_cities/icaros/krmap_functions_test.py
@gonzaponte
Copy link
Copy Markdown
Collaborator

Closes #860.
Closes #861.
Closes #862.
Closes #863.
Closes #864.

Copy link
Copy Markdown
Collaborator

@gonzaponte gonzaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another round of comments

Comment thread invisible_cities/icaros/selection_functions.py Outdated
Comment thread invisible_cities/icaros/selection_functions_test.py Outdated
Comment thread invisible_cities/icaros/lifetime_vdrift_functions.py
Comment thread invisible_cities/icaros/krmap_functions.py Outdated
Comment thread invisible_cities/icaros/krmap_functions.py Outdated
Comment thread invisible_cities/icaros/correction_functions.py Outdated
Comment thread invisible_cities/icaros/correction_functions.py
Comment thread invisible_cities/icaros/correction_functions.py Outdated
Comment thread invisible_cities/icaros/correction_functions.py Outdated
Comment thread invisible_cities/cities/zemrude.py Outdated
Copy link
Copy Markdown
Collaborator

@gonzaponte gonzaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few cosmetic changes and we are done. We will rewrite the history together to reduce the number of commits.

Comment thread invisible_cities/cities/zemrude.py Outdated
Comment thread invisible_cities/cities/zemrude.py Outdated
Comment thread invisible_cities/cities/zemrude.py Outdated
Comment thread invisible_cities/cities/zemrude.py Outdated
Comment thread invisible_cities/cities/zemrude.py Outdated
Comment thread invisible_cities/icaros/krmap_functions.py Outdated
Comment thread invisible_cities/icaros/krmap_functions.py Outdated
Comment thread invisible_cities/icaros/lifetime_vdrift_functions.py
Comment thread invisible_cities/icaros/lifetime_vdrift_functions.py
Comment thread invisible_cities/icaros/lifetime_vdrift_functions_test.py Outdated
Comment thread invisible_cities/cities/zemrude.py Outdated
Comment thread invisible_cities/cities/zemrude.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants