[손민철] 연료주입, 블랙잭 - 1단계 by MinChul-Son · Pull Request #45 · next-step/java-blackjack

MinChul-Son · 2022-02-18T14:27:13Z

안녕하세요!

연료주입 및 블랙잭 1단계를 완료하여 제출합니다!!

최대한 엔티티를 작게 유지하려는 요구사항을 만족하기 위해 잘게 쪼개려 노력했는데 적절한지 잘 모르겠네요!

블랙잭이 생각보다 많이 어렵네요.. 😂

플레이어와 딜러를 Person이라는 추상 클래스로 표현해 공통 기능을 묶어내는 식으로 구현을 진행해봤어요!

그럼 이번 미션 잘 부탁드립니다!!

기능 요구사항 - 각 보유 차량 (5대) 렌트할 때 대략적인 이동거리를 입력 - 자동차 객체 생성 시 생성자에 이동거리 주입 - 연료량 계산 - 연료 주입에 필요한 연료량 보고서 생성 프로그래밍 요구사항 - 상속 / 추상 메서드 활용 - 조건문 X Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- 주입 연료량 출력 보고서 정상 동작 여부 확인 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- 필요 기능 정의 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- Sonata - K5 - Avante Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- 자동차 추가 (addCar) - 주입 연료량 보고서 출력 (generateReport) Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

…utable Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- List<Card> 최종 점수 반환 메서드 작성 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- 각 카드 별 점수관련 클래스 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- 모든 카드(52개)를 생성시점에 초기화 - 덱에서 한장을 카드를 뽑음 - 덱이 비면 예외 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- 카드끼리의 비교를 위해 구현 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- 카드를 더 뽑을 수 있는지를 boolean으로 반환하는 canDrawCard() Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- 가지고있는 cards 객체에서 위임 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- 21보다 작다면 한장 더 뽑을 수 있음 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- Dealer - Deck - Players Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- Player Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- Card - Cards - Dealer - Deck - Person - Player - Score Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- Players Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- MatchInfo - ScoreInfo Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- InputView - ResultView Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- 파산 여부 - 블랙잭 점수 (21점) 여부 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- activePlayer - scoreInfo - matchScore Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- 딜러 / 플레이어 점수 비교 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- CardNumberTest - DealerTest - DeckTest - PlayersTest - PlayerTest - ScoreBoardTest - ScoreTest Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- Card - CardNumber - Cards - Dealer - Deck - Person - Player - Players - Score - ScoreBoard Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- CardInfo - MatchInfo - NameInfo - ScoreInfo Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- InputView - ResultView Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

vsh123

민철님 안녕하세요!
우선 리뷰가 늦어져서 죄송합니다ㅠㅠ

몇가지 코멘트를 남겼으니 확인부탁드리겠습니다!

README.md

vsh123 · 2022-02-20T12:20:41Z

src/test/java/blackjack/domain/ScoreBoardTest.java

+        dealer = new Dealer();
+        dealer.initializeDeck(deck);
+
+        scoreMap = new LinkedHashMap<>() {{


요기 컴파일 에러가 나는 것 같은데, 한번만 확인부탁드려도 될까요~?

저는 컴파일 에러가 발생하지 않는데 혹시 어떤 문제가 발생한지 알 수 있을까요?

src/main/java/rentcompany/domain/car/Avante.java

vsh123 · 2022-02-20T12:23:37Z

src/main/java/rentcompany/domain/car/Avante.java

+
+    @Override
+    public String getName() {
+        return this.getClass().getSimpleName();


클래스명을 리턴하기보다는 별도 상수를 만들어서, 해당 상수값을 리턴하는게 어떨까 싶은데요! 이에 대해서 어떻게 생각하시나요~?

이 메서드도 default method로 올려버리고 PassengerCar를 상속받는 곳에서 사용할 수 있도록 하는 것은 어떤가요??

이후에 K7이 추가된다면 K7이라는 클래스만 만들면 재사용할 수 있게끔이요!!

src/main/java/blackjack/domain/Players.java

src/main/java/blackjack/domain/Card.java

vsh123 · 2022-02-20T12:37:45Z

src/main/java/blackjack/domain/Card.java

+        return cardNumber.isAce();
+    }
+
+    public String getCardName() {


해당 역할은 View의 역할인 것 같은데요! View에서 CARD_NAME_FORMAT에 맞게 만들어주면 어떨까요?

src/main/java/blackjack/domain/Players.java

vsh123 · 2022-02-20T12:44:20Z

src/main/java/blackjack/domain/Score.java

+            .orElseThrow(() -> new RuntimeException("존재하지 않는 키입니다."));
+    }
+
+    public static Score judge(final Cards playerCards, final Cards dealerCards) {


해당 메서드가 10라인을 넘어가는 것 같아요!
아래의 요구사항을 지켜보면 어떨까요?

함수(또는 메서드)의 길이가 10라인을 넘어가지 않도록 구현한다.
함수(또는 메소드)가 한 가지 일만 하도록 최대한 작게 만들어라.

아래 사진을 보게 되면 왼쪽은 ScoreTest에서 테스트가 수행된 커버리지를 보여주는데요! 참고
if문이 많은데 테이스 케이스가 부족해보여요! 다양한 테스트를 추가해보면 어떨까요~?

kworkbee and others added 30 commits February 11, 2022 16:16

refactor: Remove Unnecessary Files empty.txt's

f1985fb

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

test: RentCompanyTest 작성

9ce23cd

- 주입 연료량 출력 보고서 정상 동작 여부 확인 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: Car / PassengerCar 작성

6d4d637

- 필요 기능 정의 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: PassengerCar 상속받은 자동차 정의

1f44c48

- Sonata - K5 - Avante Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: RentCompany 정의

4b1ce8b

- 자동차 추가 (addCar) - 주입 연료량 보고서 출력 (generateReport) Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

refactor: Add final modifier into K5 / Avante for making distance imm…

41bbc18

…utable Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

docs: 연료 주입 요구사항 반영

5a02cc7

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

docs: update README.md

c8d9181

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

test: CardNumberTest 작성

18629ed

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Player 정의

b1486aa

- List<Card> 최종 점수 반환 메서드 작성 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Score 정의

e8d2d78

- 각 카드 별 점수관련 클래스 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Suit 정의

151b0d4

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Deck 클래스 구현

16699df

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Card 클래스 equals & hashCode 오버라이드

a55c743

- 카드끼리의 비교를 위해 구현 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

refactor: CardNumber에서 사용하지 않는 Getter 제거

fa5905d

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Person의 추상 메서드 변경

3dd4f68

- 카드를 더 뽑을 수 있는지를 boolean으로 반환하는 canDrawCard() Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: 추상 메서드 오버라이드

754087e

- 가지고있는 cards 객체에서 위임 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

refactor: 불필요한 공백 및 public 키워드 제거

5c6ebe8

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Cards의 isNearTwentyOne 메서드 구현

9b05903

- 21보다 작다면 한장 더 뽑을 수 있음 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

test: 도메인 테스트 구현

7c3352a

- Dealer - Deck - Players Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

test: 도메인 테스트 구현

c0e7999

- Player Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: 도메인 기능 구현

1d6d1ef

- Card - Cards - Dealer - Deck - Person - Player - Score Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: 도메인 기능 구현

0d26b30

- Players Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: View / Controller

dfeecf4

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

refactor: domain 패키지 이동

fccc5fc

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: ResultView 뷰 로직 구현

eb50a57

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Players 이름 반환 및 카드 오픈 기능 구현

32ec9fe

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Player 카드 오픈 기능 구현

b7e9073

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

judy5050 and others added 19 commits February 17, 2022 21:51

feat: main 기능 구현

2065276

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: CardInfo 구현

15404c0

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: NameInfo 구현

d85d6e7

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: PeopleController 구현

e774da4

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

style: 코드라인 정렬

66d3ef6

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

refactor: Controller

502a5bd

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: Dto

ec398cc

- MatchInfo - ScoreInfo Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: View

1193866

- InputView - ResultView Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: Cards

a09581c

- 파산 여부 - 블랙잭 점수 (21점) 여부 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: Person (Player / Dealer)

14b4ec5

- activePlayer - scoreInfo - matchScore Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: Score / ScoreBoard

e7d4691

- 딜러 / 플레이어 점수 비교 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: 컨트롤러 구현

05ce88d

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: 도메인 구현

cd1e181

- Card - CardNumber - Cards - Dealer - Deck - Person - Player - Players - Score - ScoreBoard Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: DTO 구현

5e3663f

- CardInfo - MatchInfo - NameInfo - ScoreInfo Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: View 구현

e3f49f6

- InputView - ResultView Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

refactor: 누락된 커밋 반영

a5158db

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

refactor: 누락된 커밋 반영

007cf1c

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

docs: 완료된 요구사항 리드미 반영

10c15b2

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

vsh123 requested changes Feb 20, 2022

View reviewed changes

MinChul-Son added 10 commits February 27, 2022 17:49

refactor(rentCar): 공통 필드 부모 클래스로 이동

714705b

refactor(blackJack): 가독성을 위해 코드 분리

1c3978f

refactor(blackJack): Collections.foreack()로 변경

88ab17c

refactor(blackJack): Player 객체 생성시 생성자를 적잘한 것으로 변경

f06bc8c

refactor(blackJack): 구글 코드 스타일 적용

346e27a

refactor(blackJack): 활성화된 플레이어를 찾을 때 validation 추가

279e281

refactor(blackJack): 변수 네이밍 변경

0f3d189

test(blackJack): Card 클래스 테스트코드 작성

eb02039

test(blackJack): Cards 클래스 테스트코드 작성

e84849e

refactor(blackJack): 사용하지 않는 import문 삭제

3c711f6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[손민철] 연료주입, 블랙잭 - 1단계#45

[손민철] 연료주입, 블랙잭 - 1단계#45
MinChul-Son wants to merge 64 commits intonext-step:minchul-sonfrom
MinChul-Son:step1

MinChul-Son commented Feb 18, 2022

Uh oh!

vsh123 left a comment

Uh oh!

Uh oh!

vsh123 Feb 20, 2022

Uh oh!

MinChul-Son Feb 27, 2022

Uh oh!

Uh oh!

vsh123 Feb 20, 2022

Uh oh!

MinChul-Son Feb 27, 2022

Uh oh!

Uh oh!

Uh oh!

vsh123 Feb 20, 2022

Uh oh!

Uh oh!

Uh oh!

vsh123 Feb 20, 2022

Uh oh!

vsh123 Feb 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

MinChul-Son commented Feb 18, 2022

Uh oh!

vsh123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vsh123 Feb 20, 2022

Choose a reason for hiding this comment

Uh oh!

MinChul-Son Feb 27, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vsh123 Feb 20, 2022

Choose a reason for hiding this comment

Uh oh!

MinChul-Son Feb 27, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vsh123 Feb 20, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vsh123 Feb 20, 2022

Choose a reason for hiding this comment

Uh oh!

vsh123 Feb 20, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants