[박효정] 연료 주입, 블랙잭 (Step 1) by judy5050 · Pull Request #47 · next-step/java-blackjack

judy5050 · 2022-02-18T14:28:55Z

안녕하세요! 경록 리뷰어님 😊

연료주입과 블랙잭을 페어인 민철님,지원님과 함께 구현했습니다.
블랙잭 게임을 해본적이 없어 블랙잭 룰을 찾아보며 구현했는데
이번 미션이 제일 어려웠던거 같네요 😂

리뷰 잘 부탁드립니다. 감사합니다.

기능 요구사항 - 각 보유 차량 (5대) 렌트할 때 대략적인 이동거리를 입력 - 자동차 객체 생성 시 생성자에 이동거리 주입 - 연료량 계산 - 연료 주입에 필요한 연료량 보고서 생성 프로그래밍 요구사항 - 상속 / 추상 메서드 활용 - 조건문 X Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- 주입 연료량 출력 보고서 정상 동작 여부 확인 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- 필요 기능 정의 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- Sonata - K5 - Avante Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- 자동차 추가 (addCar) - 주입 연료량 보고서 출력 (generateReport) Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

…utable Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- List<Card> 최종 점수 반환 메서드 작성 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- 각 카드 별 점수관련 클래스 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- 모든 카드(52개)를 생성시점에 초기화 - 덱에서 한장을 카드를 뽑음 - 덱이 비면 예외 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- 카드끼리의 비교를 위해 구현 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- 카드를 더 뽑을 수 있는지를 boolean으로 반환하는 canDrawCard() Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- 가지고있는 cards 객체에서 위임 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- 21보다 작다면 한장 더 뽑을 수 있음 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- Dealer - Deck - Players Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- Player Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- Card - Cards - Dealer - Deck - Person - Player - Score Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- Players Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- MatchInfo - ScoreInfo Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- InputView - ResultView Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- 파산 여부 - 블랙잭 점수 (21점) 여부 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- activePlayer - scoreInfo - matchScore Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- 딜러 / 플레이어 점수 비교 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

- CardNumberTest - DealerTest - DeckTest - PlayersTest - PlayerTest - ScoreBoardTest - ScoreTest Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- Card - CardNumber - Cards - Dealer - Deck - Person - Player - Players - Score - ScoreBoard Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- CardInfo - MatchInfo - NameInfo - ScoreInfo Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

- InputView - ResultView Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Rok93

효정님 안녕하세요. 블랙잭 미션을 함께하게 된 김경록입니다. 🙇‍♂️
몇몇 코멘트들 남겨두었으니 확인해서 반영해주세요! 🙏
늦어서 정말 죄송합니다. 🙇‍♂️🙇‍♂️🥲

이해가 잘 안되거나 어려운 부분은 언제든지 DM주세요! 🙏

Rok93 · 2022-02-20T18:10:11Z

src/main/java/rentcompany/domain/car/Car.java

+    double getDistancePerLiter();
+    double getTripDistance();
+    String getName();


메서드 사이에는 한 줄 띄어서 가독성을 높여주세요! 🙏

Suggested change

double getDistancePerLiter();

double getTripDistance();

String getName();

double getDistancePerLiter();

double getTripDistance();

String getName();

Rok93 · 2022-02-20T18:13:42Z

src/main/java/rentcompany/domain/car/K5.java

+    private final int distance;
+
+    public K5(final int distance) {
+        this.distance = distance;
+    }


PassengerCar의 하위 구현체들은 모두 똑같은 상태 값(distance)과 (내부 구현이 완전히 똑같은 ) getTripDistance를 가지는 것 같아요. 👀

이 두 요소는 상위 클래스인 PassengerCar에 구현하면 중복된 코드를 줄일 수 있지 않을까요? 🤔

Rok93 · 2022-02-20T18:25:27Z

src/main/java/blackjack/controller/GameController.java

+    private final Players players;
+    private final Dealer dealer;


Controller는 상태를 가지면 안돼요. 👀
필요하다면 Controller의 메서드 안에서 객체를 직접 생성해서 사용해야해요. 😃

또한 Controller에 비즈니스 로직이 상당수 존재하는 것 같아요. 🙄
players와 dealer를 상태로 가지는 새로운 객체(= BlackJack)를 만들어보면 어떨까요? 🤗

Rok93 · 2022-02-21T13:47:34Z

src/main/java/blackjack/domain/Dealer.java

+package blackjack.domain;
+
+import blackjack.dto.CardInfo;
+import blackjack.dto.MatchInfo;


불필요한 import문은 제거해주세요! 🙏

Rok93 · 2022-02-21T13:50:30Z

src/main/java/blackjack/domain/Dealer.java

+    public static final int DEALER_DRAW_LIMIT = 16;
+    private static final String DEALER_NAME = "딜러";
+
+    public Dealer(final String userName,final Cards cards) {


습관적으로 코드를 자동 정렬하는 습관을 들이시면 좋아요. 🤗
mac의 경우 ⌘ + ⌥+ L 단축키로 코드 자동 정렬을 할 수 있어요. 😉

Rok93 · 2022-02-21T14:52:17Z

src/main/java/blackjack/domain/Dealer.java

+    }
+
+    @Override
+    public CardInfo openCards() {


추가로 도메인 객체의 리턴 값을 DTO로 바로 변환하여 반환하는 것 또한 View에 의존적인 코드라고 생각돼요. 🤔
반환 타입은 List 형태로 전달해보면 어떨까요? 🤔

Rok93 · 2022-02-21T14:55:52Z

src/main/java/blackjack/domain/Player.java

+
+    @Override
+    public boolean canDrawCard() {
+        return !cards.blackjack() && !cards.isBust();


Dealer는 cards.totalScore() <= DEALER_DRAW_LIMIT 조건을 만족하면 카드를 draw 할 수 있었어요. 🤗
Player 또한 cards.totalScore() <= 21를 만족하면 카드를 draw할 수 있지 않을까요? 🤔

Rok93 · 2022-02-21T14:58:01Z

src/main/java/blackjack/domain/Player.java

+    }
+
+    public Score compareScore(final Dealer dealer) {
+        return Score.judge(cards, dealer.cards);


객체의 상태 값에 바로 호출하지 말아주세요! 🙏
가급적 상태 값의 접근 제한자를 private로 둬서 외부에서 직접 접근하지 못하도록 방지해주세요! 😃
상속을 받는 경우 하위 구현체가 이 상태 값을 필요로 할 때가 있을거에요. 이런 경우에는 private 접근 제한자 때문에 이 상태 값에 직접 접근하지 못할거에요. 🥲 이런 경우에는 getter를 통해서 상위 부모 클래스의 상태 값에 접근하는 방법이 있어요. 😉

Rok93 · 2022-02-21T15:00:02Z

src/main/java/blackjack/controller/GameController.java

+        players.initializeDeck(deck);
+        dealer.initializeDeck(deck);


players가 아니라 더 상위 클래스인 Persons로 dealer와 players들을 동시에 묶는다면 이 로직은 persons.initializeDeck(deck);으로 한 번만 호출하도록 바꿔볼 수 있을 것 같아요. 🤗

Rok93 · 2022-02-21T15:15:37Z

src/main/java/blackjack/domain/Card.java

+    @Override
+    public boolean equals(Object o) {
+        if (this == o) {
+            return true;
+        }
+        if (o == null || getClass() != o.getClass()) {
+            return false;
+        }
+        Card card = (Card) o;
+        return suit == card.suit && cardNumber == card.cardNumber;
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(suit, cardNumber);
+    }


Card 객체의 동등성을 정의할 필요가 있나요? 🤔
만약 테스트 코드를 위한 equals & hashCode 정의라면 그 방법보다는 getter를 만들어서 상태 값이 실제 결과 값과 같은지 확인하는 테스트 코드로 변경하는 것이 좋다고 생각해요. 🤔

kworkbee and others added 30 commits February 11, 2022 16:16

refactor: Remove Unnecessary Files empty.txt's

f1985fb

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

test: RentCompanyTest 작성

9ce23cd

- 주입 연료량 출력 보고서 정상 동작 여부 확인 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: Car / PassengerCar 작성

6d4d637

- 필요 기능 정의 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: PassengerCar 상속받은 자동차 정의

1f44c48

- Sonata - K5 - Avante Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: RentCompany 정의

4b1ce8b

- 자동차 추가 (addCar) - 주입 연료량 보고서 출력 (generateReport) Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

refactor: Add final modifier into K5 / Avante for making distance imm…

41bbc18

…utable Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

docs: 연료 주입 요구사항 반영

5a02cc7

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

docs: update README.md

c8d9181

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

test: CardNumberTest 작성

18629ed

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Player 정의

b1486aa

- List<Card> 최종 점수 반환 메서드 작성 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Score 정의

e8d2d78

- 각 카드 별 점수관련 클래스 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Suit 정의

151b0d4

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Deck 클래스 구현

16699df

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Card 클래스 equals & hashCode 오버라이드

a55c743

- 카드끼리의 비교를 위해 구현 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

refactor: CardNumber에서 사용하지 않는 Getter 제거

fa5905d

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Person의 추상 메서드 변경

3dd4f68

- 카드를 더 뽑을 수 있는지를 boolean으로 반환하는 canDrawCard() Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: 추상 메서드 오버라이드

754087e

- 가지고있는 cards 객체에서 위임 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

refactor: 불필요한 공백 및 public 키워드 제거

5c6ebe8

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Cards의 isNearTwentyOne 메서드 구현

9b05903

- 21보다 작다면 한장 더 뽑을 수 있음 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

test: 도메인 테스트 구현

7c3352a

- Dealer - Deck - Players Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

test: 도메인 테스트 구현

c0e7999

- Player Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: 도메인 기능 구현

1d6d1ef

- Card - Cards - Dealer - Deck - Person - Player - Score Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: 도메인 기능 구현

0d26b30

- Players Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: View / Controller

dfeecf4

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

refactor: domain 패키지 이동

fccc5fc

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: ResultView 뷰 로직 구현

eb50a57

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Players 이름 반환 및 카드 오픈 기능 구현

32ec9fe

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Player 카드 오픈 기능 구현

b7e9073

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

judy5050 and others added 24 commits February 17, 2022 21:47

feat: Person 카드 오픈 및 NameDto 변환 기능 구현

d45db41

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: GameController 구현

76af023

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: Dealer CardInfo 반환 기능 구현

316a510

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: 카드 이름 반환 메서드 구현

acb4123

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

style: 매직 넘버 변경

4da5a3a

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: main 기능 구현

2065276

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: CardInfo 구현

15404c0

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: NameInfo 구현

d85d6e7

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: PeopleController 구현

e774da4

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

style: 코드라인 정렬

66d3ef6

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

refactor: Controller

502a5bd

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: Dto

ec398cc

- MatchInfo - ScoreInfo Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: View

1193866

- InputView - ResultView Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: Cards

a09581c

- 파산 여부 - 블랙잭 점수 (21점) 여부 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: Person (Player / Dealer)

14b4ec5

- activePlayer - scoreInfo - matchScore Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: Score / ScoreBoard

e7d4691

- 딜러 / 플레이어 점수 비교 Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>"

feat: 컨트롤러 구현

05ce88d

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: 도메인 구현

cd1e181

- Card - CardNumber - Cards - Dealer - Deck - Person - Player - Players - Score - ScoreBoard Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: DTO 구현

5e3663f

- CardInfo - MatchInfo - NameInfo - ScoreInfo Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

feat: View 구현

e3f49f6

- InputView - ResultView Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

refactor: 누락된 커밋 반영

a5158db

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

refactor: 누락된 커밋 반영

007cf1c

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

docs: 완료된 요구사항 리드미 반영

10c15b2

Co-authored-by: judy5050 <qkrgywjd456@naver.com> Co-authored-by: minchul-son <smc5236@gmail.com> Co-authored-by: kworkbee <g1.tommy.jeon@gmail.com>

Rok93 requested changes Feb 21, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[박효정] 연료 주입, 블랙잭 (Step 1)#47

[박효정] 연료 주입, 블랙잭 (Step 1)#47
judy5050 wants to merge 54 commits intonext-step:judy5050from
judy5050:step1

judy5050 commented Feb 18, 2022

Uh oh!

Rok93 left a comment

Uh oh!

Rok93 Feb 20, 2022

Uh oh!

Rok93 Feb 20, 2022

Uh oh!

Rok93 Feb 20, 2022

Uh oh!

Rok93 Feb 21, 2022

Uh oh!

Rok93 Feb 21, 2022

Uh oh!

Rok93 Feb 21, 2022

Uh oh!

Rok93 Feb 21, 2022

Uh oh!

Rok93 Feb 21, 2022

Uh oh!

Rok93 Feb 21, 2022

Uh oh!

Rok93 Feb 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

judy5050 commented Feb 18, 2022

Uh oh!

Rok93 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants