Fix markdown parsing in edge cases / Add task support#20
Merged
Conversation
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
commented
Mar 6, 2026
Comment on lines
-49
to
-55
| let attributes = attributedString.attributes(at: match.nsRange(atIndex: 3).lowerBound, effectiveRange: nil) | ||
|
|
||
| // Don't format parts of the string which already contain a link | ||
| if attributes.contains(where: { $0.key == .link}) { | ||
| return | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
That's annoying me a bit. I did add that part when we first introduced the library, but we didn't have test case back then. I can't think of a case where we want to have it. Could also be, that the original case was fixed in the meantime.
Removing it for now, as otherwise code inside of links will not work for example.
Ivansss
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: