feat(recent-search): add parameter to allow dynamic limit of returned items#1527
Merged
feat(recent-search): add parameter to allow dynamic limit of returned items#1527
Conversation
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1527 +/- ##
==========================================
+ Coverage 72.53% 72.56% +0.02%
==========================================
Files 40 40
Lines 1107 1108 +1
Branches 271 271
==========================================
+ Hits 803 804 +1
Misses 272 272
Partials 32 32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0cdfcbf to
e3a640c
Compare
susnux
requested changes
Mar 19, 2026
Contributor
susnux
left a comment
There was a problem hiding this comment.
can you split the PR into:
- allow setting limit
- add new prop (once server supports it)
1f94f1c to
9f3947e
Compare
Contributor
Author
… items Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
9f3947e to
5aaa694
Compare
susnux
approved these changes
Mar 26, 2026
Contributor
|
/backport to stable3 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
limitparameter togetRecentSearch()to control the maximum number of results returned<nc:last_activity/>ordering when available as a backend capability, falling back to<d:getlastmodified/>otherwiseChecklist
3. to review, feature component)stable32)AI (if applicable)