Skip to content

feat(recent-search): add parameter to allow dynamic limit of returned items#1527

Merged
susnux merged 2 commits intomainfrom
feat/1700/limit-recent-files
Mar 26, 2026
Merged

feat(recent-search): add parameter to allow dynamic limit of returned items#1527
susnux merged 2 commits intomainfrom
feat/1700/limit-recent-files

Conversation

@cristianscheid
Copy link
Copy Markdown
Contributor

@cristianscheid cristianscheid commented Mar 6, 2026

  • Resolves: #

Summary

  • Adds limit parameter to getRecentSearch() to control the maximum number of results returned
  • Adds support for <nc:last_activity/> ordering when available as a backend capability, falling back to <d:getlastmodified/> otherwise

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.56%. Comparing base (d366d98) to head (5aaa694).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1527      +/-   ##
==========================================
+ Coverage   72.53%   72.56%   +0.02%     
==========================================
  Files          40       40              
  Lines        1107     1108       +1     
  Branches      271      271              
==========================================
+ Hits          803      804       +1     
  Misses        272      272              
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cristianscheid cristianscheid force-pushed the feat/1700/limit-recent-files branch 3 times, most recently from 0cdfcbf to e3a640c Compare March 18, 2026 13:05
@cristianscheid cristianscheid self-assigned this Mar 18, 2026
@cristianscheid cristianscheid added type: enhancement 🚀 New feature or request 2. developing 2️⃣ Work in progress labels Mar 18, 2026
@cristianscheid cristianscheid marked this pull request as ready for review March 19, 2026 11:41
@cristianscheid cristianscheid added 3. to review 3️⃣ Waiting for reviews and removed 2. developing 2️⃣ Work in progress labels Mar 19, 2026
Copy link
Copy Markdown
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you split the PR into:

  • allow setting limit
  • add new prop (once server supports it)

@cristianscheid cristianscheid changed the title feat(recent-search): add parameter to allow dynamic limit of returned… feat(recent-search): add parameter to allow dynamic limit of returned items Mar 20, 2026
@cristianscheid cristianscheid force-pushed the feat/1700/limit-recent-files branch 2 times, most recently from 1f94f1c to 9f3947e Compare March 20, 2026 16:59
@cristianscheid
Copy link
Copy Markdown
Contributor Author

can you split the PR into:

  • allow setting limit
  • add new prop (once server supports it)

@susnux Done. Here's the other PR: #1547

@cristianscheid cristianscheid requested a review from susnux March 20, 2026 17:21
… items

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid cristianscheid force-pushed the feat/1700/limit-recent-files branch from 9f3947e to 5aaa694 Compare March 25, 2026 16:42
@susnux susnux merged commit aa20db2 into main Mar 26, 2026
12 checks passed
@susnux susnux deleted the feat/1700/limit-recent-files branch March 26, 2026 10:56
@susnux
Copy link
Copy Markdown
Contributor

susnux commented Mar 26, 2026

/backport to stable3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews type: enhancement 🚀 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants