Skip to content

fix(ci): remove redundant renovate[bot] check from dependabot-approve-merge workflow#696

Open
joshtrichards wants to merge 1 commit intomasterfrom
jtr/fix-drop-renovate-from-dependabot-workflow
Open

fix(ci): remove redundant renovate[bot] check from dependabot-approve-merge workflow#696
joshtrichards wants to merge 1 commit intomasterfrom
jtr/fix-drop-renovate-from-dependabot-workflow

Conversation

@joshtrichards
Copy link
Copy Markdown
Member

This PR removes the renovate[bot] trigger from the dependabot-approve-merge.yml workflow to eliminate unnecessary runner usage and improve clarity. This condition was added in #324, but is currently redundant.

Why?

  • A dedicated renovate-approve-merge.yml workflow already exists.
  • The job's inner steps are hardcoded to skip unless the branch starts with dependabot/, making Renovate triggers ineffective.
  • Prevents unnecessary job runs for every Renovate PR.

…-merge workflow

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added the 3. to review Waiting for reviews label Apr 5, 2026
@nickvergessen
Copy link
Copy Markdown
Member

Prevents unnecessary job runs for every Renovate PR.

Just remove this workflow in repos that use renovate.
No repo should use both

@joshtrichards
Copy link
Copy Markdown
Member Author

Sure, but should still be dropped from this workflow to avoid confusion, no?

@joshtrichards joshtrichards requested a review from skjnldsv April 6, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants