Skip to content

fix: action bar appereance#16097

Merged
alperozturk96 merged 23 commits into
masterfrom
fix/action-bar-appereance
Dec 15, 2025
Merged

fix: action bar appereance#16097
alperozturk96 merged 23 commits into
masterfrom
fix/action-bar-appereance

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator
  • Tests written, or not not needed

Fixes

Sets the correct toolbar style for specific screen
Sets the correct leading icon for action bar
Sets the correct currentSearchType
Fixes multiple navigation item highlight
Fixes wrong navigation item highlighting if user comes back from TrashbinActivity
Fixes file name usage in action bar in detail screens
Sets correct search fragment value
Fixes getPreviousFile(). Since currentSearchType and mSearchFragment value is correct, no need to check filter type for onBrowseUp

@alperozturk96 alperozturk96 force-pushed the fix/action-bar-appereance branch from 0a77596 to 9a58469 Compare December 8, 2025 14:03
@alperozturk96

Copy link
Copy Markdown
Collaborator Author

/backport to stable-3.35

@alperozturk96 alperozturk96 mentioned this pull request Dec 10, 2025
1 task
@alperozturk96 alperozturk96 force-pushed the fix/action-bar-appereance branch 3 times, most recently from 70c5786 to 2745a27 Compare December 12, 2025 15:04
@alperozturk96

alperozturk96 commented Dec 12, 2025

Copy link
Copy Markdown
Collaborator Author

@AndyScherzinger @tobiasKaminsky

Expected behavior:

  • The user opens the Favorites tab and sees the root favorite folder.
  • The user navigates into a favorite folder and sees the files and subfolders that belong to that favorite folder.
  • When the user goes back, they must return to the root favorite view and see the root favorite folder again.
  • This is the same for the Shared tab and the All Files tab.

Demo

Screen.Recording.2025-12-12.at.17.06.32.mp4

@tobiasKaminsky

tobiasKaminsky commented Dec 15, 2025

Copy link
Copy Markdown
Member

Quick test with user Christine:

  • open app
  • go to "favorites"
  • open "holidays & trips"
  • on Android: only favorites files are shown
  • on Web: all files are shown

@alperozturk96 alperozturk96 force-pushed the fix/action-bar-appereance branch from 3297fad to 3a3efbf Compare December 15, 2025 09:38
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
…reated or recreated

Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/action-bar-appereance branch from 3a3efbf to ee658aa Compare December 15, 2025 10:06
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code260258
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4845
Security1818
Total488483

@github-actions

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16097.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 merged commit 8b55b34 into master Dec 15, 2025
17 of 21 checks passed
@alperozturk96 alperozturk96 deleted the fix/action-bar-appereance branch December 15, 2025 12:07
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.36.0 milestone Dec 15, 2025
@AndyScherzinger

Copy link
Copy Markdown
Member

When the user goes back, they must return to the root favorite view and see the root favorite folder again.

@alperozturk96 When navigating via favorite into a subfolder navigating back up navigates you through the folder's hiearchy

@alperozturk96

Copy link
Copy Markdown
Collaborator Author

When the user goes back, they must return to the root favorite view and see the root favorite folder again.

@alperozturk96 When navigating via favorite into a subfolder navigating back up navigates you through the folder's hiearchy

Isn't it expected behavior? Since favorites, shared are shortcuts and go up means navigate one folder level up. Because user choose to go to subdirectory of some favorite folder from favorite root.

Favorite root:

A
B (A/B)

If user chooses B directly from Favorite root, one level up is A not root favorite again?

@AndyScherzinger

Copy link
Copy Markdown
Member

Isn't it expected behavior?

I don't know tbh, fine as is I guess then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants