Skip to content

fix: calculate scan interval network on main thread exception#16122

Merged
alperozturk96 merged 1 commit into
masterfrom
fix/calculate-scan-interval-network-on-main-thread
Dec 12, 2025
Merged

fix: calculate scan interval network on main thread exception#16122
alperozturk96 merged 1 commit into
masterfrom
fix/calculate-scan-interval-network-on-main-thread

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Dec 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Tests written, or not not needed
E  FATAL EXCEPTION: main
                                                                                                    Process: com.nextcloud.client, PID: 21646
                                                                                                    android.os.NetworkOnMainThreadException
                                                                                                    	at android.os.StrictMode$AndroidBlockGuardPolicy.onNetwork(StrictMode.java:1605)
                                                                                                    	at java.net.Inet6AddressImpl.lookupHostByName(Inet6AddressImpl.java:115)
                                                                                                    	at java.net.Inet6AddressImpl.lookupAllHostAddr(Inet6AddressImpl.java:103)
                                                                                                    	at java.net.InetAddress.getAllByName(InetAddress.java:1152)
                                                                                                    	at okhttp3.Dns$Companion$DnsSystem.lookup(Dns.kt:50)
                                                                                                    	at okhttp3.internal.connection.RouteSelector.resetNextInetSocketAddress(RouteSelector.kt:170)
                                                                                                    	at okhttp3.internal.connection.RouteSelector.nextProxy(RouteSelector.kt:132)
                                                                                                    	at okhttp3.internal.connection.RouteSelector.next(RouteSelector.kt:70)
                                                                                                    	at okhttp3.internal.connection.RealRoutePlanner.planConnect$okhttp(RealRoutePlanner.kt:164)
                                                                                                    	at okhttp3.internal.connection.RealRoutePlanner.plan(RealRoutePlanner.kt:75)
                                                                                                    	at okhttp3.internal.connection.FastFallbackExchangeFinder.launchTcpConnect(FastFallbackExchangeFinder.kt:119)
                                                                                                    	at okhttp3.internal.connection.FastFallbackExchangeFinder.find(FastFallbackExchangeFinder.kt:62)
                                                                                                    	at okhttp3.internal.connection.RealCall.initExchange$okhttp(RealCall.kt:298)
                                                                                                    	at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:32)
                                                                                                    	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:126)
                                                                                                    	at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:101)
                                                                                                    	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:126)
                                                                                                    	at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:85)
                                                                                                    	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:126)
                                                                                                    	at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:74)
                                                                                                    	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:126)
                                                                                                    	at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:226)
                                                                                                    	at okhttp3.internal.connection.RealCall.execute(RealCall.kt:178)
                                                                                                    	at com.nextcloud.common.OkHttpMethodBase.execute(OkHttpMethodBase.kt:147)
                                                                                                    	at com.nextcloud.client.network.ConnectivityServiceImpl.isInternetWalled(ConnectivityServiceImpl.java:122)
                                                                                                    	at com.nextcloud.utils.extensions.SyncedFolderExtensionsKt.calculateScanInterval(SyncedFolderExtensions.kt:76)
                                                                                                    	at com.owncloud.android.ui.adapter.SyncedFolderAdapter.getNextScanIndicatorText(SyncedFolderAdapter.kt:347)
                                                                                                    	at com.owncloud.android.ui.adapter.SyncedFolderAdapter.initNextScanIndicator(SyncedFolderAdapter.kt:316)
                                                                                                    	at com.owncloud.android.ui.adapter.SyncedFolderAdapter.onBindHeaderViewHolder(SyncedFolderAdapter.kt:310)
                                                                                                    	at com.afollestad.sectionedrecyclerview.SectionedRecyclerViewAdapter.onBindViewHolder(SectionedRecyclerViewAdapter.java:294)
                                                                                                    	at com.afollestad.sectionedrecyclerview.SectionedRecyclerViewAdapter.onBindViewHolder(SectionedRecyclerViewAdapter.java:17)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:7747)
                                                                                                    	at com.afollestad.sectionedrecyclerview.SectionedRecyclerViewAdapter.onBindViewHolder(SectionedRecyclerViewAdapter.java:327)
                                                                                                    	at com.afollestad.sectionedrecyclerview.SectionedRecyclerViewAdapter.onBindViewHolder(SectionedRecyclerViewAdapter.java:17)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:7847)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:6646)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6917)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6757)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6753)
                                                                                                    	at androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2362)
                                                                                                    	at androidx.recyclerview.widget.GridLayoutManager.layoutChunk(GridLayoutManager.java:584)
                                                                                                    	at androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1622)
2025-12-12 13:02:54.389 21646-21646 AndroidRuntime          com.nextcloud.client                 E  	at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:687)

@alperozturk96
fix: calculate scan interval network on main thread exception
8788602 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96

alperozturk96 commented Dec 12, 2025

Copy link
Copy Markdown
Collaborator Author

/backport to stable-3.35

@github-actions

github-actions Bot commented Dec 12, 2025

Copy link
Copy Markdown

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16122-Unit-test-12-23

AndyScherzinger
AndyScherzinger approved these changes Dec 12, 2025
View reviewed changes

@AndyScherzinger AndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Dec 12, 2025

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 merged commit 7416f51 into master Dec 12, 2025
15 of 22 checks passed
@alperozturk96 alperozturk96 deleted the fix/calculate-scan-interval-network-on-main-thread branch December 12, 2025 12:40
@backportbot backportbot Bot mentioned this pull request Dec 12, 2025
Merged
@alperozturk96 alperozturk96 added this to the Nextcloud App 3.35.0 milestone Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.35.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @AndyScherzinger