fix: connectivity service#16232
Merged
Merged
Conversation
This was referenced Jan 2, 2026
deba220 to
c424058
Compare
0261ff4 to
f2a1b3a
Compare
5b5560b to
291868d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
4f091ab to
7b9830e
Compare
7d56e29 to
4d47cb8
Compare
Collaborator
Author
|
@TheCrowned Hello. Thank you for the feedback. I updated the PR. Could you please check via latest APK file once its generated? |
AndyScherzinger
approved these changes
Apr 7, 2026
2181611 to
1fb36f6
Compare
…vice.java Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com> Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
a184c25 to
801bf6f
Compare
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://github.com/nextcloud/android/actions/runs/27681177818/artifacts/7693114999 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14681
Deduplicates
isNetworkAndServerAvailablelogicImplements
ConnectivityManager.NetworkCallbackfor better network state listeningRemoves deprecated logics
Adds better documentation
Adds exception handling for http call to prevent temporary issues thus we don't inform user with incorrect availability state
Uses for metered detection
NET_CAPABILITY_NOT_METEREDinstead ofNET_CAPABILITY_NOT_RESTRICTEDRemoves network change receiver uses listener for much better reaction to network change
Converts to Kotlin
Stores current connectivity per account since current connectivity change via account thus we should not treat new account as disconnected. Current connectivity is used for detect wifi enabled or not, server available, metered etc.
Adds smart current connectivity checker, compares previous and new one and only updates if necessary.