Skip to content

Fix video thumbnail generation for media#16252

Merged
alperozturk96 merged 1 commit into
masterfrom
fixVideoInMedia
Feb 11, 2026
Merged

Fix video thumbnail generation for media#16252
alperozturk96 merged 1 commit into
masterfrom
fixVideoInMedia

Conversation

@tobiasKaminsky

Copy link
Copy Markdown
Member

Thumbnail

  • only generate locally if image
  • use remoteId instead of localId
  • Tests written, or not not needed

use remoteId instead of localId

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code258258
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4343
Security1818
Total481481

@github-actions

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16252.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@tobiasKaminsky

Copy link
Copy Markdown
Member Author

/backport to stable-3.36

@alperozturk96 alperozturk96 merged commit e8f92c6 into master Feb 11, 2026
13 of 21 checks passed
@alperozturk96 alperozturk96 deleted the fixVideoInMedia branch February 11, 2026 12:00
pull Bot pushed a commit to Zezo-Ai/android that referenced this pull request Jun 23, 2026
Reverts part of nextcloud#16252

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
surinder-tsys pushed a commit to nextmcloud/android that referenced this pull request Jun 25, 2026
Reverts part of nextcloud#16252

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants