Skip to content

make media folder detection worker silent #16387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alperozturk96 merged 2 commits into from
Feb 25, 2026
Merged

make media folder detection worker silent #16387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c33fce0
make media folder detection worker silent
alperozturk96 Jan 28, 2026
c8ce2ce
make media folder detection worker silent
alperozturk96 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions app/src/main/java/com/nextcloud/client/jobs/MediaFoldersDetectionWork.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import android.content.Intent
import android.content.res.Resources
import android.graphics.BitmapFactory
import android.media.RingtoneManager
import android.text.TextUtils
import androidx.core.app.NotificationCompat
import androidx.work.Worker
Expand Down Expand Up @@ -49,7 +48,7 @@
import java.util.Random

@Suppress("LongParameterList") // dependencies injection
class MediaFoldersDetectionWork constructor(
class MediaFoldersDetectionWork(
private val context: Context,
params: WorkerParameters,
private val resources: Resources,
Expand Down Expand Up @@ -195,13 +194,15 @@
@Suppress("LongMethod")
private fun sendNotification(contentTitle: String, subtitle: String, user: User, path: String, type: Int) {
val notificationId = randomIdGenerator.nextInt()
val context = context
val intent = Intent(context, SyncedFoldersActivity::class.java)
intent.putExtra(NOTIFICATION_ID, notificationId)
intent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP)
intent.putExtra(NotificationWork.KEY_NOTIFICATION_ACCOUNT, user.accountName)
intent.putExtra(KEY_MEDIA_FOLDER_PATH, path)
intent.putExtra(KEY_MEDIA_FOLDER_TYPE, type)

val intent = Intent(context, SyncedFoldersActivity::class.java).apply {
putExtra(NOTIFICATION_ID, notificationId)
addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP)
putExtra(NotificationWork.KEY_NOTIFICATION_ACCOUNT, user.accountName)
putExtra(KEY_MEDIA_FOLDER_PATH, path)
putExtra(KEY_MEDIA_FOLDER_TYPE, type)
}

val pendingIntent = PendingIntent.getActivity(
context,
0,
Expand All @@ -217,41 +218,49 @@
.setSubText(user.accountName)
.setContentTitle(contentTitle)
.setContentText(subtitle)
.setSound(RingtoneManager.getDefaultUri(RingtoneManager.TYPE_NOTIFICATION))
.setAutoCancel(true)
.setSound(null)
.setVibrate(null)
.setSilent(true)
.setContentIntent(pendingIntent)

viewThemeUtils.androidx.themeNotificationCompatBuilder(context, notificationBuilder)

val disableDetection = Intent(context, NotificationReceiver::class.java)
disableDetection.putExtra(NOTIFICATION_ID, notificationId)
disableDetection.action = DISABLE_DETECTION_CLICK
val disableDetection = Intent(context, NotificationReceiver::class.java).apply {
putExtra(NOTIFICATION_ID, notificationId)
action = DISABLE_DETECTION_CLICK
}

val disableIntent = PendingIntent.getBroadcast(
context,
notificationId,
disableDetection,
PendingIntent.FLAG_CANCEL_CURRENT or PendingIntent.FLAG_IMMUTABLE
)

notificationBuilder.addAction(
NotificationCompat.Action(
R.drawable.ic_close,
context.getString(R.string.disable_new_media_folder_detection_notifications),
disableIntent
)
)

val configureIntent = PendingIntent.getActivity(
context,
notificationId,
intent,
PendingIntent.FLAG_CANCEL_CURRENT or PendingIntent.FLAG_IMMUTABLE
)

notificationBuilder.addAction(

Check failure

Code scanning / CodeQL

Use of implicit PendingIntents High

An implicit Intent is created
Loading
and sent to an unspecified third party through a PendingIntent.
An implicit Intent is created
Loading
and sent to an unspecified third party through a PendingIntent.
NotificationCompat.Action(
R.drawable.ic_settings,
context.getString(R.string.configure_new_media_folder_detection_notifications),
configureIntent
)
)

val notificationManager = context.getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager
notificationManager.notify(notificationId, notificationBuilder.build())
}
Expand Down
Loading