Skip to content

fix(manage-space-activity): app in foreground#16435

Merged
alperozturk96 merged 1 commit into
masterfrom
fix/clear-data-app-crash
Feb 4, 2026
Merged

fix(manage-space-activity): app in foreground#16435
alperozturk96 merged 1 commit into
masterfrom
fix/clear-data-app-crash

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Feb 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Tests written, or not not needed

Issue

App is crashing when user trying to open the app after deleting data.

How to reproduce?

  1. Open the app and log in.
  2. Send the app to the background.
  3. Go to the app’s settings.
  4. Begin the process to delete the app’s data and confirm.
  5. Attempt to reopen the app afterward.

@alperozturk96
fix(manage-space-activity): app in foreground
ff362f1 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
alperozturk96 commented Feb 3, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/ui/activity/ManageSpaceActivity.kt
if (result) {
finishAffinity()
finishAndRemoveTask()
exitProcess(0)

@alperozturk96 alperozturk96 Feb 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, FileDisplayActivity should not be launched after all accounts are removed on APP_RESUME. However, the app uses quite a bit of complex logic during startup.

Currently, FirstRunActivity, OnboardingServiceImpl, LauncherActivity, and AuthenticatorActivity all play a role in triggering the login flow and eventually FileDisplayActivity. To be honest, I’m not entirely sure why the app has four different launcher-related activities.

If you have any suggestions or ideas on a better approach to handle this, I’d really appreciate your feedback.

@ZetaTom @tobiasKaminsky

@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code258258
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4343
Security1818
Total481481

@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16435.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 added this to the Nextcloud App 3.36.0 milestone Feb 4, 2026
@alperozturk96 alperozturk96 merged commit 21bb51e into master Feb 4, 2026
22 of 25 checks passed
@alperozturk96 alperozturk96 deleted the fix/clear-data-app-crash branch February 4, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZetaTom ZetaTom Awaiting requested review from ZetaTom
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 33.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@alperozturk96