If enforced server, allow QR scanner, but validate url#16438
Open
tobiasKaminsky wants to merge 2 commits into
Open
If enforced server, allow QR scanner, but validate url#16438tobiasKaminsky wants to merge 2 commits into
tobiasKaminsky wants to merge 2 commits into
Conversation
tobiasKaminsky
commented
Feb 4, 2026
tobiasKaminsky
commented
Member
- Tests written, or not not needed
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
requested changes
Feb 4, 2026
| return true; | ||
| } | ||
|
|
||
| String enforcedServerList = getString(R.string.enforce_servers); |
Collaborator
There was a problem hiding this comment.
R.string.enforce_servers this will be empty and it is breaking debug login script. Please check.
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16438.apk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.