refactor(utils): return Boolean, improve exception handling and UX fo…#16453
Draft
joshtrichards wants to merge 4 commits into
Draft
refactor(utils): return Boolean, improve exception handling and UX fo…#16453joshtrichards wants to merge 4 commits into
joshtrichards wants to merge 4 commits into
Conversation
…r battery optimization launcher Adds a useful Boolean return value Improves maintainability and modularity Narrows exception handling to only expected failures Optimizes user navigation UX Signed-off-by: Josh <josh.t.richards@gmail.com>
* Show an error message if settings cannot be opened * Manual handle the positive button click to ensure the dialog stays visible if there's an error Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
test-Unit test failed, but no output was generated. Maybe a preliminary stage failed. |
Collaborator
|
Hi! Thanks for your contribution. This PR has been in draft for some time, so we'd like to check whether you're still planning to work on it. If the PR is still valid and you intend to continue, please mark it as Ready for Review (remove the draft status) and add the review label. We'll then be happy to take a look. If you no longer plan to continue with this PR, please let us know so we can keep the backlog up to date. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r battery optimization launcher
Adds a useful Boolean return value
Improves maintainability and modularity
Narrows exception handling to only expected failures Optimizes user navigation UX