refactor(FileDisplayActivity): extract file resolution and clarify ac…

[joshtrichards]

…count init logic

Addresses CI/CD detekt output:

/home/runner/actions-runner/_work/android/android/app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt - 20min debt
	LongMethod - 62/60 - [The function initFile is too long (62). The maximum length is 60.] at /home/runner/actions-runner/_work/android/android/app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt:2805:17

• Extracted the file selection and validation logic into a dedicated helper method (resolveCurrentFile)
• Renamed initFile to initializeCurrentFile for clarity
• Dropped no-op conditional parameter from updateActionBarTitleAndHomeButton() call.
• Clarified and documented process when initializing file state and user/account changes, with improved KDoc and targeted comments.
• Slightly simplified conditional UI refresh logic.
• Preserved all core functionality and app behavior; this is a structural refactor with no functional impact.

• Tests written, or not not needed

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	42	42
Correctness	74	74
Dodgy code	257	257
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	34	34
Performance	43	43
Security	18	18
Total	478	478

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16461.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[alperozturk96]

Hi! Thanks for your contribution.

This PR has been in draft for some time, so we'd like to check whether you're still planning to work on it.

If the PR is still valid and you intend to continue, please mark it as Ready for Review (remove the draft status) and add the review label. We'll then be happy to take a look.

If you no longer plan to continue with this PR, please let us know so we can keep the backlog up to date.

Thanks!