Skip to content

refactor(test): use DAO injection for ArbitraryDataProviderImpl in TestActivity#16482

Merged
alperozturk96 merged 1 commit into
masterfrom
jtr/refactor-ArbitraryDataProviderImpl-TestActivity
Feb 9, 2026
Merged

refactor(test): use DAO injection for ArbitraryDataProviderImpl in TestActivity#16482
alperozturk96 merged 1 commit into
masterfrom
jtr/refactor-ArbitraryDataProviderImpl-TestActivity

Conversation

@joshtrichards

Copy link
Copy Markdown
Member

One less layer in the deprecation stack; better alignment with #11050.

Deprecation stack: Context constructorNextcloudDatabase.getInstance(context) (deprecated but intended for legacy use) → arbitraryDataDao()

In response to this check (lint) warning:

w: file:///home/runner/work/android/android/app/src/debug/java/com/nextcloud/test/TestActivity.kt:134:21 'constructor(context: Context!): ArbitraryDataProviderImpl' is deprecated. Deprecated in Java.

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • Tests written, or not not needed

…stActivity

One less layer of deprecations

Signed-off-by: Josh <josh.t.richards@gmail.com>
@github-actions

github-actions Bot commented Feb 8, 2026

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16482.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions

github-actions Bot commented Feb 8, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger added the technical debt Refactoring or cleanup needed to improve maintainability. label Feb 8, 2026
@alperozturk96 alperozturk96 merged commit ca84d82 into master Feb 9, 2026
19 of 23 checks passed
@alperozturk96 alperozturk96 deleted the jtr/refactor-ArbitraryDataProviderImpl-TestActivity branch February 9, 2026 08:41
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.37.0 milestone Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review technical debt Refactoring or cleanup needed to improve maintainability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants