Skip to content

Forbid to change extension with template#16523

Merged
tobiasKaminsky merged 1 commit into
masterfrom
changeMimetype
Feb 24, 2026
Merged

Forbid to change extension with template#16523
tobiasKaminsky merged 1 commit into
masterfrom
changeMimetype

Conversation

@tobiasKaminsky

Copy link
Copy Markdown
Member

This will create otherwise a non-expected file, e.g template with ".md" is selected, but ".txt" is file name.

To test:

  • select template or no
  • see default extension
  • change extension
    --> dialog cannot be confirmed

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

@alperozturk96 alperozturk96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the user attempts to create a template for the first time, the dialog immediately displays a warning. The warning should not appear at the initial stage.

Instead, it would be more appropriate to show the warning only after the user attempts to modify the file extension.

Image

@alperozturk96

Copy link
Copy Markdown
Collaborator

@kra-mo Do you think message is okay?

@github-actions

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16523.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice4242
Correctness7575
Dodgy code256256
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4444
Security1818
Total479479

@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@kra-mo

kra-mo commented Feb 17, 2026

Copy link
Copy Markdown
Member

@kra-mo Do you think message is okay?

Sure, it works fine :)

@tobiasKaminsky tobiasKaminsky merged commit 3475330 into master Feb 24, 2026
18 of 21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the changeMimetype branch February 24, 2026 06:36
@tobiasKaminsky

Copy link
Copy Markdown
Member Author

/backport to stable-3.36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants