Skip to content

fix(AuthenticatorActivity): set windowSoftInputMode for the activity#16562

Draft
joshtrichards wants to merge 1 commit into
masterfrom
fix/authActivityResize
Draft

fix(AuthenticatorActivity): set windowSoftInputMode for the activity#16562
joshtrichards wants to merge 1 commit into
masterfrom
fix/authActivityResize

Conversation

@joshtrichards

Copy link
Copy Markdown
Member

The layout already uses ScrollView. Should fix #16464.

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • Tests written, or not not needed

The layout already uses ScrollView. Should fix #16464.

Signed-off-by: Josh <josh.t.richards@gmail.com>
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice4242
Correctness7575
Dodgy code256256
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4444
Security1818
Total479479

@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16562.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@ToxicMushroom

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16562.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

The issue persists, I don't see a difference on my device.

@alperozturk96

Copy link
Copy Markdown
Collaborator

Hi! Thanks for your contribution.

This PR has been in draft for some time, so we'd like to check whether you're still planning to work on it.

If the PR is still valid and you intend to continue, please mark it as Ready for Review (remove the draft status) and add the review label. We'll then be happy to take a look.

If you no longer plan to continue with this PR, please let us know so we can keep the backlog up to date.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard covers the server address during setup.

3 participants