fix(assistant): chat task flow#16624
Merged
Merged
Conversation
Collaborator
Author
|
/backport to stable-3.36 |
alperozturk96
force-pushed
the
fix/chat-task-flow
branch
from
8e71d05 to
836df29
Compare
Member
|
It is a bit odd that the highlight doesn't extend to the screen edges. Also, there being more padding on the bottom of the title banner than the top looks off. Other than these, looks nice :) |
alperozturk96
force-pushed
the
fix/chat-task-flow
branch
from
da60794 to
9eff86a
Compare
Collaborator
Author
|
alperozturk96
force-pushed
the
fix/chat-task-flow
branch
from
0755e19 to
10f133d
Compare
mpivchev
approved these changes
Mar 10, 2026
Signed-off-by: alperozturk96 <alper_ozturk@proton.me> # Conflicts: # app/src/main/java/com/nextcloud/client/assistant/conversation/ConversationScreen.kt
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
fix/chat-task-flow
branch
from
9270139 to
7abe896
Compare
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
2 tasks
Collaborator
Author
|
/backport to stable-3.36 |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16624.apk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Higlights selected conversation
Adds selected conversation title
Adds retry generation button
De-couples chat logic from asssistant view model
Better chat polling