fix(file-download-fragment): visibility of indicator#16632
Merged
Conversation
alperozturk96
changed the title
alperozturk96
force-pushed
the
file-download-fragment
branch
from
eee8db7 to
b74efb1
Compare
AndyScherzinger
approved these changes
Mar 4, 2026
AndyScherzinger
left a comment
AndyScherzinger
left a comment
Member
There was a problem hiding this comment.
Nice improvements 👍
A minor polishing could be to have rounded corners, ie 12dp?
Signed-off-by: alperozturk96 <alper_ozturk@proton.me> # Conflicts: # app/src/main/java/com/owncloud/android/ui/preview/FileDownloadFragment.java
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
file-download-fragment
branch
from
b74efb1 to
9d1c5ae
Compare
…orker migration Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Collaborator
Author
Screen.Recording.2026-03-05.at.08.29.53.mov |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16632.apk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When user downloading a file within encrypted folder downloading progress bar and text is not visible.
Changes
Uses M3 card and progress indicator
Simplifies
FileDownloadFragmentlogic and converting to the KotlinRemoves download listener since broken due to worker migration and uses indeterminate progress bar
New layout together with error card