Skip to content

fix(auto-upload): custom folder#16786

Merged
alperozturk96 merged 3 commits into
masterfrom
fix/auto-upload-custom-folder
Apr 1, 2026
Merged

fix(auto-upload): custom folder#16786
alperozturk96 merged 3 commits into
masterfrom
fix/auto-upload-custom-folder

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

Issue

  • Content observer worker was not triggering for new custom folder files
  • containsTypedFile logic was not covering all cases

Changes

  • Triggers content observer worker for custom folder files
  • Improves containsTypedFile logic and adds tests
  • Uses better naming

Demo

🔍ContentObserverWork   D  📸 content observer detected file changes.
FilesystemRepository   D  Found file: /storage/emulated/0/Download/conflict/10mb.pdf (created=1775029562000, modified=1775029562000)
SyncedFolderExtensions D  Checking file: 10mb.pdf, lastModified=1775029562000, lastScan=1775029517580
FilesystemRepository   D  inserting new file system entity: /storage/emulated/0/Download/conflict/10mb.pdf

🔄📤AutoUpload          D  pending files found, starting...
FilesystemRepository   D  Adding path to upload: /storage/emulated/0/Download/conflict/10mb.pdf
🔄📤AutoUpload          D  started, processing batch: lastId=0, count=1
SyncFolderHelper       D  auto upload remote path: /C2/10mb.pdf

🔄📤AutoUpload          D  🕒 uploading: /storage/emulated/0/Download/conflict/10mb.pdf
UploadFileOperation    D  ------- Upload File Operation Started -------
UploadsStorageManager  D  Updating /storage/emulated/0/Download/conflict/10mb.pdf with status=UPLOAD_IN_PROGRESS

OwnCloudClient         D  REQUEST HEAD /remote.php/dav/files/admin/C2/10mb.pdf
ExistenceCheck         D  HTTP 404 (file does not exist)

UploadFileOperation    D  chunked upload operation will be used
OwnCloudClient         D  REQUEST MKCOL /remote.php/dav/uploads/admin/...
OwnCloudClient         D  REQUEST PUT /remote.php/dav/uploads/.../000001
ChunkedFileOperation   D  chunk 1 uploaded, HTTP 201
OwnCloudClient         D  REQUEST MOVE ... → /C2/10mb.pdf

UploadFileOperation    D  Upload finished with HTTP 201 (Created)
UploadsStorageManager  D  status=UPLOAD_SUCCEEDED for /storage/emulated/0/Download/conflict/10mb.pdf

FileDataStorageManager D  saving file: /C2/10mb.pdf
FilesystemRepository   D  Marked file as uploaded: /storage/emulated/0/Download/conflict/10mb.pdf

🔄📤AutoUpload          D  ✅ upload completed: /storage/emulated/0/Download/conflict/10mb.pdf
🔄📤AutoUpload          D  ✅ /C2/ completed

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3838
Correctness7070
Dodgy code231231
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total441441

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/23837103241/artifacts/6215552505
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 merged commit d4fd2af into master Apr 1, 2026
19 of 22 checks passed
@alperozturk96 alperozturk96 deleted the fix/auto-upload-custom-folder branch April 1, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants