Skip to content

Use built-in Kotlin#16855

Merged
alperozturk96 merged 3 commits into
masterfrom
builtInKotlin
Apr 17, 2026
Merged

Use built-in Kotlin#16855
alperozturk96 merged 3 commits into
masterfrom
builtInKotlin

Conversation

@tobiasKaminsky

@tobiasKaminsky tobiasKaminsky commented Apr 15, 2026

Copy link
Copy Markdown
Member

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • Tests written, or not not needed

tobiasKaminsky
tobiasKaminsky commented Apr 15, 2026
View reviewed changes
Comment thread app/build.gradle.kts

applicationVariants.configureEach {
outputs.configureEach {
if (this is ApkVariantOutputImpl) this.outputFileName = "${this.baseName}-${this.versionCode}.apk"

@tobiasKaminsky tobiasKaminsky Apr 15, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not need it.
Since there was no easy migration, I simply removed it.

@github-actions

github-actions Bot commented Apr 15, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/24452798875/artifacts/6449827683
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/24548933420/artifacts/6489233852
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@tobiasKaminsky
Use built-in Kotlin
530f2e6 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
suppress false-positive spotbugs for Dagger
84ed04a 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/24549321828/artifacts/6489367723
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@tobiasKaminsky
fix test
d8c62d4 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6969
Dodgy code226226
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total432432

@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/24549623169/artifacts/6489486372
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 mentioned this pull request Apr 17, 2026
Closed
@alperozturk96 alperozturk96 merged commit 0a91cb5 into master Apr 17, 2026
16 of 20 checks passed
@alperozturk96 alperozturk96 deleted the builtInKotlin branch April 17, 2026 06:36
@alperozturk96 alperozturk96 added this to the Nextcloud App 33.2.0 milestone Apr 17, 2026
@alperozturk96 alperozturk96 added the technical debt Refactoring or cleanup needed to improve maintainability. label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 Awaiting requested review from alperozturk96

Assignees

No one assigned

Labels

3. to review technical debt Refactoring or cleanup needed to improve maintainability.

Projects

None yet

Milestone

Nextcloud App 34.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tobiasKaminsky @alperozturk96