Skip to content

fix(offline-sync): remote path npe#16872

Merged
alperozturk96 merged 2 commits into
masterfrom
fix/npe-offline-sync
Apr 17, 2026
Merged

fix(offline-sync): remote path npe#16872
alperozturk96 merged 2 commits into
masterfrom
fix/npe-offline-sync

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

Issue

E  Work [ id=38e277fa-a127-4183-8f21-5a084f2fa44f, tags={ com.nextcloud.client.jobs.OfflineSyncWork,*,name:periodic_offline_sync,timestamp:1776261120706,class:OfflineSyncWork } ] failed because it threw an exception/error
                                                                                                    java.lang.NullPointerException: Parameter specified as non-null is null: method com.nextcloud.client.database.dao.FileDao_Impl.getFileByEncryptedRemotePath, parameter path
                                                                                                    	at com.nextcloud.client.database.dao.FileDao_Impl.getFileByEncryptedRemotePath(Unknown Source:2)
                                                                                                    	at com.owncloud.android.datamodel.FileDataStorageManager.getFileByPath(FileDataStorageManager.java:367)
                                                                                                    	at com.owncloud.android.datamodel.FileDataStorageManager.getFileByEncryptedRemotePath(FileDataStorageManager.java:145)
                                                                                                    	at com.owncloud.android.datamodel.FileDataStorageManager.getFileByPath(FileDataStorageManager.java:141)
                                                                                                    	at com.owncloud.android.operations.SynchronizeFileOperation.run(SynchronizeFileOperation.java:190)
                                                                                                    	at com.owncloud.android.lib.common.operations.RemoteOperation.execute(RemoteOperation.java:132)
                                                                                                    	at com.owncloud.android.lib.common.operations.RemoteOperation.execute(RemoteOperation.java:141)
                                                                                                    	at com.owncloud.android.operations.common.SyncOperation.execute(SyncOperation.java:51)
                                                                                                    	at com.nextcloud.client.jobs.OfflineSyncWork.recursive(OfflineSyncWork.kt:84)
                                                                                                    	at com.nextcloud.client.jobs.OfflineSyncWork.doWork(OfflineSyncWork.kt:53)
                                                                                                    	at androidx.work.Worker.startWork$lambda$0(Worker.kt:64)
                                                                                                    	at androidx.work.Worker$$ExternalSyntheticLambda0.invoke(D8$$SyntheticClass:0)
                                                                                                    	at androidx.work.WorkerKt.future$lambda$2$lambda$1(Worker.kt:100)
                                                                                                    	at androidx.work.WorkerKt$$ExternalSyntheticLambda1.run(D8$$SyntheticClass:0)
                                                                                                    	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156)
                                                                                                    	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651)
                                                                                                    	at java.lang.Thread.run(Thread.java:1119)

Fix

Do not fail whole worker

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96

Copy link
Copy Markdown
Collaborator Author

/backport to stable-33.1.0

@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6969
Dodgy code226226
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total432432

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/24553690052/artifacts/6491058630
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 merged commit 4bccad2 into master Apr 17, 2026
16 of 21 checks passed
@alperozturk96 alperozturk96 deleted the fix/npe-offline-sync branch April 17, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant