Kotlin conversion of UploadFileOperation#17108
Conversation
hannesa2
force-pushed
the
KotlinUploadFileOperation
branch
4 times, most recently
from
118a028 to
9efa156
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/27058366047/artifacts/7453194578 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Log_OC.d(TAG, "Creating temporal folder") | ||
| val temporalParent = targetFile.parentFile | ||
|
|
||
| if (!temporalParent!!.mkdirs() && !temporalParent.isDirectory) { |
| Log_OC.d(TAG, "Creating temporal folder") | ||
| val temporalParent = targetFile.parentFile | ||
|
|
||
| if (!temporalParent!!.mkdirs() && !temporalParent.isDirectory) { |
| } | ||
|
|
||
| Log_OC.d(TAG, "Creating temporal file") | ||
| if (!targetFile.createNewFile() && !targetFile.isFile) { |
| } | ||
|
|
||
| Log_OC.d(TAG, "Creating temporal file") | ||
| if (!targetFile.createNewFile() && !targetFile.isFile) { |
| } else { | ||
| `in` = FileInputStream(sourceFile) | ||
| } | ||
| out = FileOutputStream(targetFile) |
| private fun move(sourceFile: File, targetFile: File) { | ||
| if (targetFile != sourceFile) { | ||
| val expectedFolder = targetFile.parentFile | ||
| Files.createDirectories(expectedFolder!!.toPath()) |
| val expectedFolder = targetFile.parentFile | ||
| Files.createDirectories(expectedFolder!!.toPath()) | ||
|
|
||
| if (expectedFolder.isDirectory) { |
| Files.createDirectories(expectedFolder!!.toPath()) | ||
|
|
||
| if (expectedFolder.isDirectory) { | ||
| if (!sourceFile.renameTo(targetFile)) { |
| if (expectedFolder.isDirectory) { | ||
| if (!sourceFile.renameTo(targetFile)) { | ||
| // try to copy and then delete | ||
| Files.createFile(targetFile.toPath()) |
| Files.createFile(targetFile.toPath()) | ||
| try { | ||
| FileInputStream(sourceFile).channel.use { inChannel -> | ||
| FileOutputStream(targetFile).channel.use { outChannel -> |
hannesa2
force-pushed
the
KotlinUploadFileOperation
branch
2 times, most recently
from
b5e43ff to
317a04b
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/27059364136/artifacts/7453518059 |
Signed-off-by: Hannes Achleitner <hannes.software@gmx.at>
hannesa2
force-pushed
the
KotlinUploadFileOperation
branch
from
317a04b to
79ab1da
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/27059855267/artifacts/7453666242 |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
alperozturk96
left a comment
alperozturk96
left a comment
There was a problem hiding this comment.
Thanks for working on this.
I'd be more comfortable taking an incremental approach, for example, first extracting smaller pieces into separate Kotlin classes and then gradually converting the remaining parts. That would make the changes easier to review, test, and debug if anything goes wrong.
|
@alperozturk96 After 5 weeks. you want to multiply the afford here by splitting it in smaller junks. you should re-think your comfortable it's-better-for-me-way |
3 participants
I was investigation how to change Wifi upload mechanism, and I found that causing class is still Java 👎
So I converted it in advance to Kotlin without changing anything in the logic. I hope that tests will check, if there is something now faulty