Fix a typo in CONTRIBUTING.md#17195
Conversation
The code block had the language "bash" written at the end of the block, causing part of the file to be rendered incorrectly. Signed-off-by: sitegui <2801575+sitegui@users.noreply.github.com>
|
Just to give more context: I'm also having problems with the auto-upload feature. I saw the call for help in #16550, so I would like to use this as an excuse to learn more about the internals of this project and maybe help with the fixes. 🤓 Do you have the auto-upload architecture documented somewhere? |
AndyScherzinger
left a comment
There was a problem hiding this comment.
2nd commit 3d2955b needs to be removed as is is not in scope for the PR and it is also a set of false changes we would not except, like the logging flag change as well as the app-id and cmake changes
Best to find an existing ticket or raising a new one to not mix-up different issues in a single Github issue. The first commit was fine from my pov, but the 2nd commit makes it a blocker. |
3d2955b to
978b49e
Compare
|
Thanks @AndyScherzinger ! Sorry for the second commit, it was a mistake. I think it was auto-pushed when I ran |
|
No worries @sitegui and thanks you very much for the fix! 🙏 Merged 🚀 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Hello Nextcloud Android team o/
I've started studying the codebase and I've noticed a small typo in the markdown of CONTRIBUTING.md that, causing part of the file to be rendered incorrectly.
🖼️ Screenshots
🏚️ Before
https://github.com/nextcloud/android/blob/448b459165b78f376a7bfb4db9a8562daa310938/CONTRIBUTING.md#testing
🏡 After
https://github.com/sitegui/nextcloud-android/blob/978b49eb281efca974355c4d197cc868e6c977b1/CONTRIBUTING.md#testing
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)