Skip to content

fix(connectivity-service): usages#17233

Merged
alperozturk96 merged 5 commits into
masterfrom
fix/connectivity-service-scope-usages
Jun 24, 2026
Merged

fix(connectivity-service): usages#17233
alperozturk96 merged 5 commits into
masterfrom
fix/connectivity-service-scope-usages

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

  • Fixes connectivity service usage in dialog fragments
  • Uses factory to remove duplicate construction of connectivity service for tests

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/28012768568/artifacts/7815520104
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the fix/connectivity-service-scope-usages branch from 6a2b428 to 59fc0aa Compare June 24, 2026 05:09
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/28076708849/artifacts/7840746137
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

tobiasKaminsky

This comment was marked as resolved.

Sign in to view

@alperozturk96
Rename .java to .kt
18b446c 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix(connectivity-service): usages
a75f779 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
42e57f5 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix tests
7b52b6d 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/connectivity-service-scope-usages branch from aa971e5 to 7b52b6d Compare June 24, 2026 10:00
@alperozturk96
wip
2a52617 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/28090708080/artifacts/7846435549
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3131
Correctness6767
Dodgy code211211
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness2929
Performance4141
Security1616
Total405405

@alperozturk96 alperozturk96 merged commit c257ebd into master Jun 24, 2026
19 of 23 checks passed
@alperozturk96 alperozturk96 deleted the fix/connectivity-service-scope-usages branch June 24, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @tobiasKaminsky