Skip to content

fix(login): loading ui#17310

Merged
alperozturk96 merged 2 commits into
masterfrom
fix/login-loading-ui
Jul 10, 2026
Merged

fix(login): loading ui#17310
alperozturk96 merged 2 commits into
masterfrom
fix/login-loading-ui

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Before After
before after

Before

Screen_recording_20260710_105536.mp4

After

after.mp4

Fixes

Duplicate loading indicator
Overlapping of "Cancel" button

@alperozturk96
fix(login): loading ui
a4e698b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 added this to the Nextcloud App 34.1.0 milestone Jul 10, 2026
@alperozturk96 alperozturk96 added the papercut Annoying recurring issue with possibly simple fix label Jul 10, 2026
@alperozturk96 alperozturk96 requested a review from kra-mo July 10, 2026 09:04
kra-mo
kra-mo approved these changes Jul 10, 2026
View reviewed changes

@kra-mo kra-mo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More lines removed too, really nice :)

@alperozturk96 alperozturk96 mentioned this pull request Jul 10, 2026
Open
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29081432145/artifacts/8223344682
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
fix lint
d5e56b9 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness6666
Dodgy code213213
Experimental11
Malicious code vulnerability22
Multithreaded correctness2929
Performance4141
Security1919
Total403403

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29082563208/artifacts/8223576440
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 merged commit 46249a3 into master Jul 10, 2026
19 of 22 checks passed
@alperozturk96 alperozturk96 deleted the fix/login-loading-ui branch July 10, 2026 09:44
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17310-IT-master-10-43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kra-mo kra-mo kra-mo approved these changes
@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review papercut Annoying recurring issue with possibly simple fix

Projects

None yet

Milestone

Nextcloud App 34.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @kra-mo