Skip to content

fix(file-data-storage-manager): save file with parent network on main thread#17316

Open
alperozturk96 wants to merge 1 commit into
masterfrom
fix/network-on-main-thread-exception
Open

fix(file-data-storage-manager): save file with parent network on main thread#17316
alperozturk96 wants to merge 1 commit into
masterfrom
fix/network-on-main-thread-exception

Conversation

@alperozturk96

Copy link
Copy Markdown
Collaborator

… thread exception

Issue

Exception com.owncloud.android.operations.RemoteOperationFailedException:
  at com.owncloud.android.datamodel.FileDataStorageManager.saveFileWithParent (FileDataStorageManager.java:625)
  at com.owncloud.android.datamodel.FileDataStorageManager.createPendingFile (FileDataStorageManager.java:237)
  at com.owncloud.android.datamodel.FileDataStorageManager.addCreateFileOfflineOperation (FileDataStorageManager.java:202)
  at com.owncloud.android.ui.activity.FileDisplayActivity.requestUploadOfFilesFromFileSystem$lambda$0 (FileDisplayActivity.kt:1133)
  at com.owncloud.android.ui.activity.FileDisplayActivity$$ExternalSyntheticLambda16.onComplete (D8$$SyntheticClass)
  at com.nextcloud.client.network.ConnectivityServiceImpl.lambda$isNetworkAndServerAvailable$0 (ConnectivityServiceImpl.java:78)
  at com.nextcloud.client.network.ConnectivityServiceImpl$$ExternalSyntheticLambda1.run (D8$$SyntheticClass)
  at android.os.Handler.handleCallback (Handler.java:1029)
  at android.os.Handler.dispatchMessage (Handler.java:107)
  at android.os.Looper.loopOnce (Looper.java:274)
  at android.os.Looper.loop (Looper.java:369)
  at android.app.ActivityThread.main (ActivityThread.java:10090)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:616)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1137)
Caused by android.os.NetworkOnMainThreadException:
  at android.os.StrictMode$AndroidBlockGuardPolicy.onNetwork (StrictMode.java:1737)
  at java.net.SocketInputStream.read (SocketInputStream.java:172)
  at java.net.SocketInputStream.read (SocketInputStream.java:143)
  at java.io.BufferedInputStream.fill (BufferedInputStream.java:239)
  at java.io.BufferedInputStream.read (BufferedInputStream.java:258)
  at org.apache.commons.httpclient.HttpConnection.isStale (HttpConnection.java:506)
  at org.apache.commons.httpclient.HttpConnection.closeIfStale (HttpConnection.java:431)
  at org.apache.commons.httpclient.MultiThreadedHttpConnectionManager$HttpConnectionAdapter.closeIfStale (MultiThreadedHttpConnectionManager.java:1313)
  at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry (HttpMethodDirector.java:382)
  at org.apache.commons.httpclient.HttpMethodDirector.executeMethod (HttpMethodDirector.java:171)
  at org.apache.commons.httpclient.HttpClient.executeMethod (HttpClient.java:397)
  at org.apache.commons.httpclient.HttpClient.executeMethod (HttpClient.java:323)
  at com.owncloud.android.lib.common.OwnCloudClient.executeMethod (OwnCloudClient.java:192)
  at com.owncloud.android.lib.common.OwnCloudClient.executeMethod (OwnCloudClient.java:155)
  at com.owncloud.android.lib.resources.files.ReadFileRemoteOperation.run (ReadFileRemoteOperation.java:72)
  at com.owncloud.android.lib.common.operations.RemoteOperation.execute (RemoteOperation.java:132)
  at com.owncloud.android.lib.common.operations.RemoteOperation.execute (RemoteOperation.java:141)
  at com.owncloud.android.datamodel.FileDataStorageManager.saveFileWithParent (FileDataStorageManager.java:611)

… thread exception

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness6666
Dodgy code213213
Experimental11
Malicious code vulnerability22
Multithreaded correctness2929
Performance4141
Security1919
Total403403

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29096062048/artifacts/8228943926
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant