-
Notifications
You must be signed in to change notification settings - Fork 31
feat: Implement a command palette with Ctrl-K shortcut #2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3876ee8 to
f56408c
Compare
f643d86 to
0452d55
Compare
|
Sorry for the noise. Like a smartpicker, but the action is not inserted in the actual page but in the target=> Add a reminder, create a deck card, message a friend add something on your calendar. Like be in mail summon this palette => Create a deck card which has a link to the mail Productivity 🚀 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing stuff @juliusknorr <3
A couple of comments from my side:
- We don't need a dialog for this title, the input label is enough
- In the screencast, the height of the dialog varies depending on the search results list. Would it be possible to make the dialog's height fixed? Or maybe even better we could have the height change depending on the results, but only "cut the container from the bottom" and have the search field itself fixed in place on the page.
Edit: sorry for the ping different Julius
|
Different julius pinged but, I'll look into those. @marcoambrosini Regarding the comment from @Aveyron-RetD I think this is an interesting idea worth to discuss with the other designers or in planning calls if we think this is interesting for all apps, but we could start with collectives to try this out in daily use and then learn from it for a more global implementation in a next round. |
Signed-off-by: Julius Knorr <jus@bitgrid.net>
0452d55 to
6e4b7d4
Compare
|
@marcoambrosini Adjusted Also set to ready for review for some code feedback from the others ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliusknorr writing to you from design team meeting. Everyone likes it a lot :)
A couple of things that came up, both non blocking:
- The sub-lines of the commands are a bit redundant. What do you think about removing those?
- It would be nice if there was a hint about this somewhere in the UI, maybe the main landing page after first run? Or there could be a shortcut section in the settings like in talk
@Aveyron-RetD regarding connecting this with other apps commands and resources, we agree that that could be really good eventually, but we prefer to start small and test this out in collectives first. This would already be very useful in its current form.
also ping @jancborchardt for when you're back from vacation :)
Signed-off-by: Julius Knorr jus@bitgrid.net
📝 Summary
This is a common feature in IDEs and also other tools like Notion, for Nextcloud this has only been discussed in nextcloud/notes#1200
This is a first attempt out of personal need to implement this in collectives.
Also pulling in @marcoambrosini for some design feedback and to check if something like this was discussed in other places in the design team as well.
Currently implemented
Navigation
Commands:
🖼️ Screenshots
Kapture.2025-12-31.at.13.39.41.webm
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)