Updated API calls NextcloudKit dependency to breaking changes in 7.3.3#10109
Merged
Conversation
i2h3
added
os: 🍎 macOS
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
Collaborator
Author
|
/backport to stable-33.0 |
…king changes in 7.3.3 Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
i2h3
force-pushed
the
i2h3/fix/nextcloudkit
branch
from
97ce9b3 to
d659a17
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the macOS File Provider integration to accommodate breaking API changes introduced in NextcloudKit 7.3.3, adjusting the RemoteInterface abstraction and related call sites/mocks accordingly.
Changes:
- Bump NextcloudKit dependency to 7.3.3 (and update SwiftPM lockfile pins accordingly).
- Update
RemoteInterface.downloadAsyncto the new return shape and adapt usages in production code and test mocks. - Adjust NextcloudKit RemoteInterface bridging logic to re-derive metadata from the new callback payload, and tighten a helper closure signature with
@Sendable.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| shell_integration/MacOSX/NextcloudFileProviderKit/Tests/Interface/MockRemoteInterface.swift | Updates mock downloadAsync to match NextcloudKit 7.3.3 API shape. |
| shell_integration/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderKitMocks/TestableRemoteInterface.swift | Updates testable RemoteInterface stub for new downloadAsync return tuple. |
| shell_integration/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderKit/Item/Item+Fetch.swift | Adjusts download call sites to the new tuple return structure. |
| shell_integration/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderKit/Interface/RemoteInterface.swift | Updates RemoteInterface.downloadAsync signature to match the dependency change. |
| shell_integration/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderKit/Interface/NextcloudKit+RemoteInterface.swift | Adapts NextcloudKit bridging callback to new parameters and reconstructs returned metadata. |
| shell_integration/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderKit/Extension/FileProviderExtension.swift | Marks signalEnumerator completion handler as @Sendable. |
| shell_integration/MacOSX/NextcloudFileProviderKit/Package.swift | Bumps NextcloudKit dependency requirement to 7.3.3. |
| Nextcloud Desktop Client.xcworkspace/xcshareddata/swiftpm/Package.resolved | Updates resolved dependency versions/revisions for the new dependency graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10109.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
github-project-automation
Bot
moved this from 🧭 Planning evaluation (don't pick)
to ☑️ Done
in 💻 Desktop Clients team
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NextcloudKit 7.3.3 shipped breaking API changes due to this pull request. Some adaptions were required.