Open
Conversation
Now that other operation are supported by the web UI, we can use all permissions. Signed-off-by: Louis <louis@chmn.me>
artonge
added
3. to review
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
susnux
reviewed
Feb 26, 2026
| crtime: new Date(), | ||
| mtime: new Date(), | ||
| permissions: Permission.READ, // TODO: allow more permissions once we support that | ||
| permissions: Permission.ALL, |
Contributor
There was a problem hiding this comment.
I think we still need to strip share permissions
Collaborator
Author
There was a problem hiding this comment.
Share permissions were actually what triggered me to change that line. It should be in since you implemented sharing in the web UI, no?
Contributor
There was a problem hiding this comment.
Yes but the vanilla Nextcloud sharing still needs to be disabled - thats why we still remove share permissions here:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that other operation are supported by the web UI, we can use all permissions.