[stable33] fix(a11y): make team folder edit buttons keyboard-operable#4911
Open
backportbot[bot] wants to merge 4 commits into
Open
[stable33] fix(a11y): make team folder edit buttons keyboard-operable#4911backportbot[bot] wants to merge 4 commits into
backportbot[bot] wants to merge 4 commits into
Conversation
The team folders admin settings table rendered its rename and delete row controls as bare <a> elements with an onClick handler but no href. Anchors without an href are not part of the tab order and do not respond to Enter/Space, so keyboard-only and screen-reader users could not rename or delete a team folder. Replace those non-interactive anchors with native <button type="button"> elements that carry the existing onClick handlers and a discernible aria-label, restoring keyboard operability and a non-empty accessible name. Add minimal SCSS to strip the default button chrome so the controls keep their prior icon/text appearance. Fixes #4466 Signed-off-by: Matt Van Horn <mvanhorn@gmail.com>
Address review feedback: an aria-label of just "Rename" overrode the visible mount-point text as the button's accessible name, exposing every row only as "Rename". Include the folder name in the label so each row stays identifiable to screen-reader and voice-control users. Signed-off-by: Matt Van Horn <mvanhorn@gmail.com>
Address review feedback: the FolderGroups column also renders an <a class="action-rename">, so an unscoped reset (notably color: inherit) leaked into that anchor and overrode its lighter link color. Scope the button-chrome reset to button.action-rename so the sibling anchor keeps its existing styling. Signed-off-by: Matt Van Horn <mvanhorn@gmail.com>
The mountpoint name moved from <a> to <button class="action-rename">, so the td.mountpoint a rule (color: main-text, bold) no longer matched and the folder name lost its emphasis. Extend the selector to button.action-rename; its higher specificity overrides the color: inherit / font: inherit from the button-chrome reset. Verified: stylelint clean, vite production build passes. Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
backportbot
Bot
added
bug
3. to review
susnux
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #4825