feat: jmap support - part 1 by SebastianKrupinski · Pull Request #12711 · nextcloud/mail

SebastianKrupinski · 2026-04-12T23:09:43Z

Summary

Resolves: JMAP Protocol Abstraction and Routing Infrastructure #12609
Added php-jmap-client dependency
Modified test workflow to start additional mail server with jmap support
Added jmap specific console command to create account (mail:account:create-jmap)
Added jmap specific console command to create account (mail:account:create-jmap)
Modified existing imap console command to create account (mail:account:create-imap) with alias to old command (mail:account:create)
Modified existing imap console command to update account (mail:account:update-imap) with alias to old command (mail:account:create)
Added unified console test command (mail:account:test) with alias to old (mail:account:diagnose)
Added a protocol factory to create the correct client and connectors
Added database migrations

SebastianKrupinski · 2026-06-28T13:44:51Z

On hold for #12711 (comment)

Done. Implemented

ChristophWurst

⚠️ Some of the new files are AGPL-3.0-only but have to be AGPL-3.0-or-later
⚠️ New column remote_id is not indexed but used in WHERE -> full table scan on our biggest table
⚠️ Version is migration class names is outdated
⚠️ php-http/discovery plugin has to be allowed at installation. Change should be committed

Lots of dead code, but it will be used in part 2, ignoring.

SebastianKrupinski · 2026-07-13T14:50:03Z

⚠️ Some of the new files are AGPL-3.0-only but have to be AGPL-3.0-or-later

Done, the remaining two files (CreateImapAccount and UpdateImapAccount) where renamed... So the "AGPL-3.0-only" should probably stay

⚠️ New column remote_id is not indexed but used in WHERE -> full table scan on our biggest table

Done

⚠️ Version is migration class names is outdated

Done

⚠️ php-http/discovery plugin has to be allowed at installation. Change should be committed

Done

ChristophWurst

Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run composer update or composer update <package name>.

SebastianKrupinski · 2026-07-13T18:52:24Z

Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run composer update or composer update <package name>.

Done

kesselb · 2026-07-15T15:38:32Z

+	/**
+	 * Synchronize all relevant mailboxes for the account.
+	 */
+	public function syncAll(Account $account, bool $force = false): void;


Does that belong here?

Yes, it sync messages for an entire account

kesselb · 2026-07-15T15:51:51Z

+				json_decode($imapClient->capability->serialize(), true)
+			);
+			sort($capabilities);
+			$output->writeln('Capabilities: <info>' . implode(', ', $capabilities) . '</info>');


The old formatting, using newlines, was much better to read.

You need to run this command on feat/jmap-2, the command is truncated in this PR, because its missing code to make the rest work

kesselb · 2026-07-15T15:53:03Z

+			sort($capabilities);
+			$output->writeln('Capabilities: <info>' . implode(', ', $capabilities) . '</info>');
+
+			$output->writeln('<info>IMAP connection test passed</info>');


Can we add "Account has $messages messages in $nMailboxes mailboxes" back, why the removal?

You need to run this command on feat/jmap-2, the command is truncated in this PR, because its missing code to make the rest work

ChristophWurst · 2026-07-20T13:54:56Z

@kesselb ready to merge?

kesselb · 2026-07-20T20:25:41Z

+interface IMailboxConnector {
+
+	/**
+	 * Synchronise the list of mailboxes for the given account.


Suggested change

* Synchronise the list of mailboxes for the given account.

* Synchronize the list of mailboxes for the given account.

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

SebastianKrupinski · 2026-07-21T14:00:53Z

Thank you @kesselb

SebastianKrupinski self-assigned this Apr 12, 2026

SebastianKrupinski added this to 💌 📅 👥 Groupware team Apr 12, 2026

SebastianKrupinski added the 2. developing label Apr 12, 2026

github-project-automation Bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Apr 12, 2026

SebastianKrupinski force-pushed the feat/jmap-1 branch 2 times, most recently from e01d756 to 234e641 Compare April 12, 2026 23:21

SebastianKrupinski force-pushed the feat/jmap-1 branch 4 times, most recently from 961bbd3 to fc4e6c8 Compare April 21, 2026 12:38

SebastianKrupinski changed the title ~~feat: jmap support - initial~~ feat: jmap support - part 1 Apr 21, 2026

SebastianKrupinski force-pushed the feat/jmap-1 branch 9 times, most recently from 8d19aa3 to db410bf Compare April 21, 2026 21:32

SebastianKrupinski marked this pull request as ready for review April 21, 2026 21:33

SebastianKrupinski requested review from ChristophWurst, GretaD and kesselb as code owners April 21, 2026 21:33

SebastianKrupinski force-pushed the feat/jmap-1 branch from db410bf to 06324ac Compare April 23, 2026 16:01

ChristophWurst approved these changes Apr 23, 2026

View reviewed changes

SebastianKrupinski added 3. to review and removed 2. developing labels Apr 23, 2026

SebastianKrupinski force-pushed the feat/jmap-1 branch 2 times, most recently from 3991cc8 to 8c5effd Compare April 23, 2026 17:26

SebastianKrupinski force-pushed the feat/jmap-1 branch 8 times, most recently from 9aeb152 to 4f1e284 Compare June 28, 2026 12:34

SebastianKrupinski requested a review from ChristophWurst June 28, 2026 13:53

ChristophWurst requested changes Jul 2, 2026

View reviewed changes

odzhychko reviewed Jul 2, 2026

View reviewed changes

Comment thread lib/Command/CreateJmapAccount.php Outdated

SebastianKrupinski force-pushed the feat/jmap-1 branch from 4f1e284 to 2da2b1b Compare July 13, 2026 14:44

ChristophWurst requested changes Jul 13, 2026

View reviewed changes

SebastianKrupinski requested a review from ChristophWurst July 13, 2026 18:52

ChristophWurst approved these changes Jul 15, 2026

View reviewed changes

kesselb reviewed Jul 15, 2026

View reviewed changes

kesselb approved these changes Jul 20, 2026

View reviewed changes

kesselb reviewed Jul 20, 2026

View reviewed changes

feat: jmap support - initial

61bfd97

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

SebastianKrupinski force-pushed the feat/jmap-1 branch from 2cacd3f to 61bfd97 Compare July 20, 2026 23:32

kesselb merged commit b01aff2 into main Jul 21, 2026
42 of 43 checks passed

github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Jul 21, 2026

kesselb deleted the feat/jmap-1 branch July 21, 2026 13:12

	* Synchronise the list of mailboxes for the given account.
	* Synchronize the list of mailboxes for the given account.

Uh oh!

Conversation

SebastianKrupinski commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

SebastianKrupinski commented Jun 28, 2026

Uh oh!

ChristophWurst left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SebastianKrupinski commented Jul 13, 2026

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

SebastianKrupinski commented Jul 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChristophWurst commented Jul 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SebastianKrupinski commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SebastianKrupinski commented Apr 12, 2026 •

edited

Loading

ChristophWurst left a comment •

edited

Loading