Skip to content

Fix search provider replace URL with URL with deeplink#13172

Open
taiebot wants to merge 3 commits into
nextcloud:mainfrom
taiebot:Deeplink-searchprovider
Open

Fix search provider replace URL with URL with deeplink#13172
taiebot wants to merge 3 commits into
nextcloud:mainfrom
taiebot:Deeplink-searchprovider

Conversation

@taiebot

@taiebot taiebot commented Jun 28, 2026

Copy link
Copy Markdown

I do not know which other apps use this search provider, but this is used by the tables app. This change replace the URL with a deeplink URL (there was a todo)

This has been tested with the tables app, this will allow sharing links between multiple mailboxes.

see the screenshots below
image

image

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@SoleroTG for review

@welcome

welcome Bot commented Jun 28, 2026

Copy link
Copy Markdown

Thanks for opening your first pull request in this repository! ✌️

@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

nitpick: you can inline the url generation

@ChristophWurst

Copy link
Copy Markdown
Member

You have to fix the commit. Message should be fix(search): use deep link. it needs the AI trailer and a sign-off.

taiebot added 2 commits July 18, 2026 14:22
I'm currently working through the GitHub web interface, which doesn't allow amending existing commit messages.

Also address the nitpick

AI-assisted: Claude (Sonnet 4.7)

Signed-off-by: taiebot <dedreuil@yahoo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants