Skip to content

fix: actions menu for envelope#13296

Open
madbob wants to merge 1 commit into
nextcloud:mainfrom
madbob:issue_12586
Open

fix: actions menu for envelope#13296
madbob wants to merge 1 commit into
nextcloud:mainfrom
madbob:issue_12586

Conversation

@madbob

@madbob madbob commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

I've simplified a bit the management of actions menu in EnvelopeSkeleton, to handle the many involved conditions.

Notes:

  • the ugly setTimeout in handleActionsUpdateOpen is to delay a bit the status change for the closed menu; without it, the flickering menu mentioned in Action menu flickers for some actions #12586 cannot be really fixed. I've already opened an issue for nextcloud-vue in order to have a proper way to manage this
  • almost unrelated to the target issue - but still related to actions menu - are the changes in MessageHTMLBody. The (untracked) issue is that NcActions registers a global handler to intercept clicks made on whole document and determines if the opened menu has to be closed, but clicks occurring over the iframe of MessageHTMLBody are "absorbed" by the iframe itself and do not bubble to the rest of the document. This change is intended to pre-intercept those clicks and properly deliver them to that global callback: now action menus are closed also when clicking on the HTML body of an email (which often occupies the large portion of the screen). If those changes seem too unrelated to the scope of this PR, I can split them in a different dedicated PR
  • wandering up and down EnvelopeSkeleton I've found a few props that are never set by anyone and I guess can be removed. forceDisplayActions has been here suppressed, while counterNumber and counterType are still there. The commit introducing them (0b15b42) provides no hints about their scope. If no-one has any suggestion about their meaning and intended usage, I can remove them within this same PR

Fixes #12586

Signed-off-by: Roberto Guido <info@madbob.org>
@ChristophWurst

Copy link
Copy Markdown
Member

Thanks! Will try to review soon 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action menu flickers for some actions

2 participants