fix: improved widget for mailbox selection#13318
Open
madbob wants to merge 1 commit into
Open
Conversation
Signed-off-by: Roberto Guido <info@madbob.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diving into #8726 I stumbled upon
MailboxInlinePicker, the only user of @riophae/vue-treeselect, a not-so-lightweight dependency which did not received any update in the last 7 years.So I rewrote it using the more familiar
NcSelect, which do not permit nested navigation and selection of subfolders. Let you evaluate if this is an acceptable loss.This PR includes:
MailboxInlinePicker, as specified aboveAccountDefaultsSettings, to adapt to the newMailboxInlinePicker, remove most of the duplicated code around, and separate the flags to disable the single inputs while saving (which was the original request of Default folder selection jumps #8726)ActionFileinto, also to be adapted to the newMailboxInlinePickervue-treeselectMy only concern is about the filter on
mailboxHasRights, which has been here removed. It is not entirely clear to me what kind of check was here performed, but if it was required perhaps the same elaboration should be added also to Quick Folders selections (cfr. #13305) and similar folder/subfolder selections.Fixes #8726
Note: if this PR is merged, I recommend to remove then the dependency from
@riophae/vue-treeselectinpackage.json: I avoided to change that myself in order to not mess up withpackage-lock.json