fix(tags): add accessible name to tag modal#13325
Merged
Merged
Conversation
Member
Author
|
/backport to stable5.10 |
madbob
approved these changes
Jul 20, 2026
Member
Author
That seems to be intended: https://github.com/nextcloud-libraries/nextcloud-vue/blob/5de5b9ce20c8b85d929837498d2cfe9f05c76747/src/components/NcModal/NcModal.vue#L640-L649 |
NcModal requires a name or labelId for accessibility; without it Vue warns and screen readers get no dialog label. Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
fix/tag-modal-a11y-name
branch
from
July 20, 2026 15:24
f0abe44 to
0a6eb9d
Compare
odzhychko
approved these changes
Jul 20, 2026
Member
Author
|
Pushed an alternative that now reference an existing heading as modal accessibility label. This way we can keep the light opacity of the backdrop. |
odzhychko
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

NcModal requires a name or labelId for accessibility; without it Vue warns and screen readers get no dialog label;
Assisted-by: Claude:claude-opus-4-8
Discovered while testing #13257.
How to test
main: console Vue warning
here: ✨
🤖 AI (if applicable)