Make the note icon area useful by moving favorites to the left icon #1730
+51
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronovgj
force-pushed
the
feat/favorites
branch
from
846c52f to
e91d099
Compare
juliusknorr
added
enhancement
…make it clickable Signed-off-by: Grigorij Aronov <aronovgj@gmx.net>
aronovgj
force-pushed
the
feat/favorites
branch
from
e91d099 to
207965c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The left‑side FileDocumentOutlineIcon is always shown but doesn't have any function, and it disappears for favorites. This is inconsistent and wastes space. This change turns that area into a visible, clickable favorite toggle, so the star state is always visible and the icon slot has a purpose.
Changes
Why
Keeps the UI consistent (favorites vs non‑favorites), makes the icon slot functional, and improves discoverability of the favorite action.
This is how it would look now: