Front/webpush

[p1gp1g]

This PR uses the new web push support (#2662) to get push notifications on the web application, even when nextcloud isn't opened in the browser.

It achieves 2 things:

• it gives push notifications when nextcloud isn't opened: this is particularly useful for collaborative work, as nexcloud isn't always opened but we can expect to be notified anyway. (I won't miss call, polls, or events anymore)
• it gives real time notifications, without the notify_push app (which adds a websocket support to nextcloud). It should reduce load on the server as the periodic fetch is reduce to once every 15min. When the server get a notification for a user, it sends it to the user through its push server (all modern browser are connected to a push server)

To work, this PR needs to add worker-src 'self' to the CSP by default:

https://github.com/nextcloud/server/blob/master/lib/public/AppFramework/Http/EmptyContentSecurityPolicy.php#L62

-	protected $allowedWorkerSrcDomains = null;
+	protected $allowedWorkerSrcDomains = ["'self'"];

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[p1gp1g]

I've rebased the PR on the master branch, and updated following some changes we did: apptype (array) => appTypes (String)

[Elsensee]

I really love this PR and I wanted WebPush support in Nextcloud for some time already, so I am super sorry for all this!

But another thing I noticed was, that you don’t seem to handle delete notifications at all? I am not even sure, how this could be properly handled. You could call getNotifications() and then close() but on Android this might still appear in the notification history. Also, when the tab is closed you must show a notification on push.
Alternatively, you could replace the notification with some silent notification with title "This notification has been deleted" and then quickly close() it, but I don’t know if that will actually work.

I assume, integrating UnifiedPush for the mobile apps will be a lot more straight forward as most logic should already be in place there. It’s just a shame, that you have to do all this manual legwork for browsers. 😅

[p1gp1g]

I suppose this is a typo and you're not sorry for this ?

BTW, your help is very welcome, thanks. I will show a generic notification if we don't have the right content. You can also suggest code directly or open PR on my repo if you want :)

Regarding UnifiedPush: the implementation is already done, I've a few things to do following changes on the backend Pr :D

[Elsensee]

I just didn't want to come across as rude and complaining about a lot, especially since I am not affiliated with Nextcloud. :)

And nice, I will see what my time allows me to do on contributing. :)

I’m looking forward to the UnifiedPush implementation!

[p1gp1g]

No problem, code review is done for that ! At the end we have a better solution

[p1gp1g]

How do you do your tests ? I've tested on Firefox and Chromium - both on Linux, but all platforms should work

You still need your browser to be opened, else it isn't connected to their push server anymore. Except on mobile, where the browser can be waken by the device push service (APNS, FCM, UnifiedPush). But you don't have to have Nextcloud in one of the opened tab

[nickvergessen]

How do you do your tests ?

1. Open Nextcloud with this branch of notification app
2. Grant notification permissions in browser
3. Close the tab
4. occ notification:generate --dummy userId 2

Expectation

See a notification

Actual

nothing

When 3 is skipped and you just navigate to another tab, it works.

[p1gp1g]

I wonder if it isn't because the test notification isn't formatted the same way than actual notifications. Can you do the same thing but send a Talk message or comment a shared file for the 4th step - to fire a real notification ?

And, if something is wrong, then you may want to look at the Service : about:debugging on Firefox > This Firefox > And you will be able to inspect the service worker

[nickvergessen]

And, if something is wrong, then you may want to look at the Service : about:debugging on Firefox > This Firefox > And you will be able to inspect the service worker

After going there is was missing the entry, it showed up after loading the page again, but it was disabled. After pressing "Start" it worked, and after a few moments it's off again, but now also starts again when receiving a notification:

[nickvergessen]

I wonder if it isn't because the test notification isn't formatted the same way than actual notifications.

Well it is an accepted format. Any app can push notifications and it should the same for all of those. But lets see how the testing continues.

[p1gp1g]

You shouldn't have to click "Start", it is done automatically on push. Maybe the service worker wasn't registered for any reason, a cache or something