Skip to content

refactor(apps): Declare strict types where missing#48859

Closed
provokateurin wants to merge 1 commit intomasterfrom
refactor/apps/declare-strict-types
Closed

refactor(apps): Declare strict types where missing#48859
provokateurin wants to merge 1 commit intomasterfrom
refactor/apps/declare-strict-types

Conversation

@provokateurin
Copy link
Copy Markdown
Member

Summary

Done with rector. The CI is going to fail, as not everything is working correctly yet.

Feel free to contribute a few fixes to resolve these problems. (if they are part of the app logic please make a separate PR and backport it, if it is just tests then you can push them on this branch)

@miaulalala already did a bunch of fixes to the dav app at the conf. Quite often it is actually the tests that provide wrong data while the application logic is just fine.

Checklist

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin added 2. developing Work in progress 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Oct 23, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Oct 23, 2024
@nickvergessen
Copy link
Copy Markdown
Member

  • I am against a mass-change like this 🙈
    As I had to experience myself it can have hidden issues that are not straight forward to debug with "random" side-effects fix(versions): Fix strict trimming of version paths files_accesscontrol#595
  • There will be cases that are not covered by tests or integration tests and it will be a huge pain to discover and draw it back to this. Especially in the file related handling.

@provokateurin
Copy link
Copy Markdown
Member Author

Makes sense, would you be fine if I limit it to apps with very high test coverage?
It's still useful to test it once, even if we don't enable it in the end, as it will point us to problems we can fix either way.

@provokateurin provokateurin removed the 3. to review Waiting for reviews label Oct 25, 2024
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
@skjnldsv skjnldsv added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@blizzz blizzz modified the milestones: Nextcloud 33, Nextcloud 34 Feb 16, 2026
@provokateurin
Copy link
Copy Markdown
Member Author

#58194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants