fix(files_sharing): Use share password policy for password generation#58221
Open
fix(files_sharing): Use share password policy for password generation#58221
Conversation
nfebe
requested review from
sorbaugh,
susnux and
szaimen
and removed request for
a team
nfebe
force-pushed
the
fix/share-password-policy-generation
branch
3 times, most recently
from
77608d0 to
0072c5e
Compare
Pass context=sharing when calling the password_policy API to generate passwords that comply with share-specific password policies. The fallback generator now also respects the sharing policy settings from capabilities (minLength, special characters, etc.) when the API is unavailable. Fixes: nextcloud/password_policy#870 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/share-password-policy-generation
branch
from
0072c5e to
cb46856
Compare
artonge
reviewed
Mar 25, 2026
| // Character sets for password generation | ||
| const CHARS_LOWER = 'abcdefgijkmnopqrstwxyz' | ||
| const CHARS_UPPER = 'ABCDEFGHJKLMNPQRSTWXYZ' | ||
| const CHARS_DIGITS = '23456789' |
Collaborator
There was a problem hiding this comment.
Missing 1?
Suggested change
| const CHARS_DIGITS = '23456789' | |
| const CHARS_DIGITS = '123456789' |
| // note: some chars removed on purpose to make them human friendly when read out | ||
| const passwordSet = 'abcdefgijkmnopqrstwxyzABCDEFGHJKLMNPQRSTWXYZ23456789' | ||
| // Character sets for password generation | ||
| const CHARS_LOWER = 'abcdefgijkmnopqrstwxyz' |
Collaborator
There was a problem hiding this comment.
Suggested change
| const CHARS_LOWER = 'abcdefgijkmnopqrstwxyz' | |
| const CHARS_LOWER = 'abcdefghijklmnopqrstuvwxyz' |
| const passwordSet = 'abcdefgijkmnopqrstwxyzABCDEFGHJKLMNPQRSTWXYZ23456789' | ||
| // Character sets for password generation | ||
| const CHARS_LOWER = 'abcdefgijkmnopqrstwxyz' | ||
| const CHARS_UPPER = 'ABCDEFGHJKLMNPQRSTWXYZ' |
Collaborator
There was a problem hiding this comment.
Suggested change
| const CHARS_UPPER = 'ABCDEFGHJKLMNPQRSTWXYZ' | |
| const CHARS_UPPER = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ' |
| const array = new Uint8Array(10) | ||
| const ratio = passwordSet.length / 255 | ||
| getRandomValues(array) | ||
| // Fallback: generate password based on sharing policy from capabilities |
Member
There was a problem hiding this comment.
Why is a fallback needed? I think this will only cause problems down the line when the implementations in the frontend and backend get out of sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass context=sharing when calling the password_policy API to generate passwords that comply with share-specific password policies.
The fallback generator now also respects the sharing policy settings from capabilities (minLength, special characters, etc.) when the API is unavailable.
Fixes: nextcloud/password_policy#870